Attention is currently required from: Nico Huber, Martin Roth, Idwer Vollering, Paul Menzel, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56803 )
Change subject: util/genbuild_h: micro-adjust the regexp used to set COREBOOT_MAJOR_VERSION
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56803/comment/e5df638f_a16a8537
PS3, Line 7: COREBOOT_MAJOR_VERSION
COREBOOT_MINOR_VERSION, actually.
Alternatively, borrow CB:55468 's commit message.
File util/genbuild_h/genbuild_h.sh:
https://review.coreboot.org/c/coreboot/+/56803/comment/92a40241_4f7ded0b
PS2, Line 73: printf "#define COREBOOT_MAJOR_VERSION %d\n#define COREBOOT_MINOR_VERSION %d\n" `git describe --match [0-9].[0-9]* | sed 's/([0-9]).([0-9][0-9]*).*/\1 \2/'`
Please explain in the commit message, what difference ([0-9]+) versus ([0-9][0-9]*) makes.
CB:55468 says that + is not part of POSIX Basic Regular Expressions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56803
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c0c260fd8d42e23a612a353a288e472cc068c8e
Gerrit-Change-Number: 56803
Gerrit-PatchSet: 3
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 19 Aug 2021 13:14:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment