Attention is currently required from: Bora Guvendik, Selma Bensaid, Hsuan-ting Chen, Paul Menzel, Tim Wawrzynczak, Bernardo Perez Priego. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58099 )
Change subject: mb/intel/adlrvp: Add hook function to return EC in RW status ......................................................................
Patch Set 9:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58099/comment/d26b5337_a6e78f7e PS7, Line 7: mb/adlrvp
mb/intel/adlrvp
Ack
https://review.coreboot.org/c/coreboot/+/58099/comment/91139e26_a392c990 PS7, Line 9: EC_IN_RW signal from EC GPIO is connected to GPIO E7 : of SOC. The function reads this GPIO to check if EC is in : RW (un trusted) or RO (trusted)
Please reflow for 75 characters per line, and please add a dot/period to the end of sentences.
Ack
https://review.coreboot.org/c/coreboot/+/58099/comment/b49a7a52_d3f1f6cc PS7, Line 11: un trusted
untrusted
Ack
File src/mainboard/intel/adlrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/58099/comment/4335b723_901ddf4c PS7, Line 51: int
bool or unsigned int?
i followed the definition in src/include/bootmode.h
int get_ec_is_trusted(void);
File src/mainboard/intel/adlrvp/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/58099/comment/e2079a7a_476bf27d PS7, Line 15: #define GPIO_EC_IN_RW GPP_E7
Please align with a tabs as done above.
Ack