Change in coreboot[master]: ec/google/chromeec: Lower the severity of the debug statement

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Karthik Ramasubramanian (Code Review)

3 Nov 2020 3 Nov '20

9:43 a.m.

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47175 )

Change subject: ec/google/chromeec: Lower the severity of the debug statement ......................................................................

ec/google/chromeec: Lower the severity of the debug statement

Integrated TypeC MUX is used only in certain SoCs and hence the missing devicetree configuration is not an error. Lower the severity of the debug statement.

BUG=b:172186858 TEST=Build and boot to OS in Drawlat.

Change-Id: Ieb76e1ccfd04f1628617b2665b05be6718a25f81 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/ec/google/chromeec/ec_acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/47175/1

diff --git a/src/ec/google/chromeec/ec_acpi.c b/src/ec/google/chromeec/ec_acpi.c index 344f5f4..3d1e5a9 100644 --- a/src/ec/google/chromeec/ec_acpi.c +++ b/src/ec/google/chromeec/ec_acpi.c @@ -141,7 +141,7 @@ continue;

if (!config->mux_conn[i]) - printk(BIOS_ERR, "ERROR: Mux connector info missing for Type-C port " + printk(BIOS_INFO, "Mux connector info missing for Type-C port " "#%d\n", i);

usb2_port = NULL;

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Tim Wawrzynczak (Code Review)

3 Nov 3 Nov

10:03 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47175 )

Change subject: ec/google/chromeec: Lower the severity of the debug statement ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb76e1ccfd04f1628617b2665b05be6718a25f81 Gerrit-Change-Number: 47175 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 03 Nov 2020 18:03:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10:09 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47175 )

Change subject: ec/google/chromeec: Lower the severity of the debug statement ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47175/1/src/ec/google/chromeec/ec_a... File src/ec/google/chromeec/ec_acpi.c:

https://review.coreboot.org/c/coreboot/+/47175/1/src/ec/google/chromeec/ec_a... PS1, Line 143: if (!config->mux_conn[i]) : printk(BIOS_INFO, "Mux connector info missing for Type-C port " : "#%d\n", i); This was actually my fault. I had asked Tim to print an error here in case mux_conn is not found. But, as you stated, this is not really true for all platforms. We can have designs with Type-C connectors but without internal mux in the SoC. I think we should just drop this print and check and trust that the mainboard will provide the right configuration.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb76e1ccfd04f1628617b2665b05be6718a25f81 Gerrit-Change-Number: 47175 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 03 Nov 2020 18:09:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

10:40 a.m.

New subject: Change in coreboot[master]: ec/google/chromeec: Remove the check for Internal TypeC MUX

Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47175

to look at the new patch set (#2).

Change subject: ec/google/chromeec: Remove the check for Internal TypeC MUX ......................................................................

ec/google/chromeec: Remove the check for Internal TypeC MUX

Integrated TypeC MUX is used only in certain SoCs and hence the missing devicetree configuration is not an error. Remove the check for internal TypeC MUX device and the associated debug statement.

BUG=b:172186858 TEST=Build and boot to OS in Drawlat.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/47175/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb76e1ccfd04f1628617b2665b05be6718a25f81 Gerrit-Change-Number: 47175 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

10:40 a.m.

New subject: Change in coreboot[master]: ec/google/chromeec: Remove the check for Internal TypeC MUX

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47175 )

Change subject: ec/google/chromeec: Remove the check for Internal TypeC MUX ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47175/1/src/ec/google/chromeec/ec_a... File src/ec/google/chromeec/ec_acpi.c:

...

This was actually my fault. I had asked Tim to print an error here in case mux_conn is not found. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb76e1ccfd04f1628617b2665b05be6718a25f81 Gerrit-Change-Number: 47175 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 03 Nov 2020 18:40:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11:15 a.m.

New subject: Change in coreboot[master]: ec/google/chromeec: Remove the check for Internal TypeC MUX

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47175 )

Change subject: ec/google/chromeec: Remove the check for Internal TypeC MUX ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb76e1ccfd04f1628617b2665b05be6718a25f81 Gerrit-Change-Number: 47175 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 03 Nov 2020 19:15:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

5 Nov 5 Nov

11:06 a.m.

New subject: Change in coreboot[master]: ec/google/chromeec: Remove the check for Internal TypeC MUX

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47175 )

Change subject: ec/google/chromeec: Remove the check for Internal TypeC MUX ......................................................................

ec/google/chromeec: Remove the check for Internal TypeC MUX

Integrated TypeC MUX is used only in certain SoCs and hence the missing devicetree configuration is not an error. Remove the check for internal TypeC MUX device and the associated debug statement.

BUG=b:172186858 TEST=Build and boot to OS in Drawlat.

Change-Id: Ieb76e1ccfd04f1628617b2665b05be6718a25f81 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47175 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/ec/google/chromeec/ec_acpi.c 1 file changed, 0 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/ec/google/chromeec/ec_acpi.c b/src/ec/google/chromeec/ec_acpi.c index 344f5f4..448ea4d 100644 --- a/src/ec/google/chromeec/ec_acpi.c +++ b/src/ec/google/chromeec/ec_acpi.c @@ -140,10 +140,6 @@ if (rv) continue;

- if (!config->mux_conn[i]) - printk(BIOS_ERR, "ERROR: Mux connector info missing for Type-C port " - "#%d\n", i); - usb2_port = NULL; usb3_port = NULL; usb4_port = NULL;

-- To view, visit https://review.coreboot.org/c/coreboot/+/47175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb76e1ccfd04f1628617b2665b05be6718a25f81 Gerrit-Change-Number: 47175 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1473

days inactive

1475

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Furquan Shaikh (Code Review)
Karthik Ramasubramanian (Code Review)
Tim Wawrzynczak (Code Review)