Attention is currently required from: Ashish Kumar Mishra, Balaji Manigandan.
Nico Huber has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile conditional
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
Hi, thanks for the patch. The `:` should always work, however also always
lets make invoke another shell process, just to do nothing. What is your
exact evironment? make version, shell version? I couldn't reproduce this
with any make/shell combination. How could I reproduce the issue?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 4
Gerrit-Owner: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Thu, 15 Aug 2024 21:28:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes