Attention is currently required from: Angel Pons, Felix Singer, Julius Werner, Lean Sheng Tan, Nico Huber.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83615?usp=email )
Change subject: util/cbfstool/cbfs-payload-linux: Do not compress bzImage ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83615/comment/90ac96c3_fdfcbef2?usp... : PS3, Line 12: erros
typo: errors
Done
File util/cbfstool/cbfs-payload-linux.c:
https://review.coreboot.org/c/coreboot/+/83615/comment/1622c488_d23a4766?usp... : PS3, Line 159: comp_func_ptr compress_func = compression_function(algo);
Looks like `algo` only needs to be different when `type == PAYLOAD_SEGMENT_CODE`. […]
In my opinion that makes it look like PAYLOAD_SEGMENT_CODE is the deciding factor upon which to decide whether to compress or not. But PAYLOAD_SEGMENT_CODE doesn't really have anything to do with the decision whether or not to compress. It is mostly just coincidence, that the bzImage is the code segment and other ones aren't. I am also a fan of removing it from the global `struct bzpayload` state, since global states are at least for me usually harder to keep track of and read. And it is just used in this single place so I don't see a reason to have a global state for it in the first place.
If you don't mind I would leave it like that.
https://review.coreboot.org/c/coreboot/+/83615/comment/5e4e862e_6ad6f63c?usp... : PS3, Line 294: // There is no point in compressing the bzImage (it is already compressed)
nit: consistent comment style
Done