Change in coreboot[master]: [VERY WIP]tests/cpu/x86/smm: Add unit tests - coreboot-gerrit

13 Apr 2022


      Attention is currently required from: Arthur Heymans.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63560 )
Change subject: [VERY WIP]tests/cpu/x86/smm: Add unit tests
......................................................................
Patch Set 6:
(3 comments)
File tests/cpu/x86/smm/smm_loader.c:
https://review.coreboot.org/c/coreboot/+/63560/comment/b1982277_ce19c9ec 
PS6, Line 12: 0x10000
nit: 64 * KiB
https://review.coreboot.org/c/coreboot/+/63560/comment/1702006f_03087e2b 
PS6, Line 45: 0x4000
nit: 16 * KiB
https://review.coreboot.org/c/coreboot/+/63560/comment/51dac127_388563fc 
PS6, Line 54: #define setup_rmodule(mod , c)
Can it be a function?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63560
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7462fa6155b8f8085256a027692cbead0ca3f08e
Gerrit-Change-Number: 63560
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 13 Apr 2022 07:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment