Attention is currently required from: Dolan Liu, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, Weimin Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80259?usp=email )
The change is no longer submittable: All-Comments-Resolved and Code-Review are unsatisfied now.
Change subject: mb/google/nissa/var/anraggar: Config DP AUX BIAS according to fw_config
......................................................................
Patch Set 11: -Code-Review
(1 comment)
File src/mainboard/google/brya/variants/anraggar/variant.c:
https://review.coreboot.org/c/coreboot/+/80259/comment/9353a04f_8d920e98 :
PS11, Line 26: config->tcss_aux_ori = 4;
You should have two tcss_aux_ori values right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80259?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53974ec7444912a63d0fe0a9303c9e5d6941f68d
Gerrit-Change-Number: 80259
Gerrit-PatchSet: 11
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Wed, 07 Feb 2024 04:51:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment