Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69496 )
Change subject: mb/google: Fix log messages ......................................................................
mb/google: Fix log messages
Change 'printk(BIOS_DEBUG, "ERROR:' to printk(BIOS_ERR, "'.
Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/69496 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/mainboard/google/auron/variants/buddy/variant.c M src/mainboard/google/beltino/lan.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/jecht/lan.c M src/mainboard/google/rambi/variants/ninja/lan.c M src/mainboard/google/rambi/variants/sumo/lan.c 6 files changed, 28 insertions(+), 24 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/auron/variants/buddy/variant.c b/src/mainboard/google/auron/variants/buddy/variant.c index 397b541..5af2502 100644 --- a/src/mainboard/google/auron/variants/buddy/variant.c +++ b/src/mainboard/google/auron/variants/buddy/variant.c @@ -55,8 +55,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; }
@@ -72,8 +71,7 @@
offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/beltino/lan.c b/src/mainboard/google/beltino/lan.c index 1104ea7..baadf15 100644 --- a/src/mainboard/google/beltino/lan.c +++ b/src/mainboard/google/beltino/lan.c @@ -36,8 +36,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; }
@@ -53,8 +52,7 @@
offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index f428e69..67f371c 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -40,7 +40,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, (unsigned char)*offset); retval = 0; } @@ -58,8 +58,7 @@ offset = search(key, (char *)search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); @@ -149,7 +148,7 @@ kbd_type = EC_KBD_JP; } } else { - printk(BIOS_DEBUG, "Error: Could not locate VPD area\n"); + printk(BIOS_ERR, "Could not locate VPD area\n"); }
printk(BIOS_DEBUG, "Setting Keyboard type in EC to "); diff --git a/src/mainboard/google/jecht/lan.c b/src/mainboard/google/jecht/lan.c index a431393..1f90aa7 100644 --- a/src/mainboard/google/jecht/lan.c +++ b/src/mainboard/google/jecht/lan.c @@ -36,8 +36,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; }
@@ -53,8 +52,7 @@
offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/rambi/variants/ninja/lan.c b/src/mainboard/google/rambi/variants/ninja/lan.c index 0abbffe..8dfdb08 100644 --- a/src/mainboard/google/rambi/variants/ninja/lan.c +++ b/src/mainboard/google/rambi/variants/ninja/lan.c @@ -35,8 +35,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; }
@@ -52,8 +51,7 @@
offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/rambi/variants/sumo/lan.c b/src/mainboard/google/rambi/variants/sumo/lan.c index 66083ae..168f8b5 100644 --- a/src/mainboard/google/rambi/variants/sumo/lan.c +++ b/src/mainboard/google/rambi/variants/sumo/lan.c @@ -35,8 +35,7 @@ retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; }
@@ -52,8 +51,7 @@
offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);
-
Martin L Roth (Code Review)