Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41758 )
Change subject: mb/intel/jasperlake_rvp: Camera remove DSDT and enable SSDT ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41758/1/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/Kconfig:
https://review.coreboot.org/c/coreboot/+/41758/1/src/drivers/intel/mipi_came... PS1, Line 4: y
In my past experience I didn't have to make this change. […]
Done
https://review.coreboot.org/c/coreboot/+/41758/8/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/Kconfig:
https://review.coreboot.org/c/coreboot/+/41758/8/src/drivers/intel/mipi_came... PS8, Line 4: default y
Why? This will add MIPI_CAMERA driver to every board. […]
Reverted and added to jasperlake_rvp/Kconfig
https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasperl... PS1, Line 50: variant/acpi/camera.asl
Should this and the related files be deleted?
Done
https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasperl... PS1, Line 439: chip drivers/intel/mipi_camera : register "acpi_uid" = "327680" : register "acpi_name" = ""IPU0"" : register "chip_name" = ""Camera and Imaging Subsystem"" : register "device_type" = "INTEL_ACPI_CAMERA_CIO2" : : register "cio2_num_ports" = "2" : register "cio2_lanes_used[0]" = "2" : register "cio2_lanes_used[1]" = "2" : register "cio2_lane_endpoint[0]" = ""^I2C4.CAM0"" : register "cio2_lane_endpoint[1]" = ""^I2C5.CAM0"" : : device pci 05.0 on end # RP4 : end
Normally there'd be a separate CIO device. […]
Done