Attention is currently required from: Arthur Heymans. Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/63060
to review the following change.
Change subject: mb/*/bootblock.c: Fix set but unused variable over inb loop ......................................................................
mb/*/bootblock.c: Fix set but unused variable over inb loop
Change-Id: Iba80c4a5960c6fb59f542b33e8e769576ccfed59 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/amd/olivehill/bootblock.c M src/mainboard/asus/am1i-a/bootblock.c 2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/63060/1
diff --git a/src/mainboard/amd/olivehill/bootblock.c b/src/mainboard/amd/olivehill/bootblock.c index efdf57d..319914f 100644 --- a/src/mainboard/amd/olivehill/bootblock.c +++ b/src/mainboard/amd/olivehill/bootblock.c @@ -7,12 +7,11 @@ void bootblock_mainboard_early_init(void) { int i; - u32 val;
/* Disable PCI-PCI bridge and release GPIO32/33 for other uses. */ pm_write8(0xea, 0x1);
/* On Larne, after LpcClkDrvSth is set, it needs some time to be stable, because of the buffer ICS551M */ for (i = 0; i < 200000; i++) - val = inb(0xcd6); + inb(0xcd6); } diff --git a/src/mainboard/asus/am1i-a/bootblock.c b/src/mainboard/asus/am1i-a/bootblock.c index 6e71962..b465a55 100644 --- a/src/mainboard/asus/am1i-a/bootblock.c +++ b/src/mainboard/asus/am1i-a/bootblock.c @@ -103,7 +103,7 @@
void bootblock_mainboard_early_init(void) { - u32 val, i; + u32 i;
/* Disable PCI-PCI bridge and release GPIO32/33 for other uses. */ pm_write8(0xea, 0x1); @@ -128,5 +128,5 @@ * because of the buffer ICS551M */ for (i = 0; i < 200000; i++) - val = inb(0xcd6); + inb(0xcd6); }