Hello Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37666
to review the following change.
Change subject: cbfstool: Bump C version to C11 ......................................................................
cbfstool: Bump C version to C11
cbfstool depends on vboot headers, and vboot expects to be able to use modern C features like _Static_assert(). It just so happens that it doesn't do that in any headers included from cbfstool right now, but that may change. Let's switch cbfstool to a newer version to prevent that from becoming a problem.
Change-Id: I884e1bdf4ec21487ddb1bca57ef5dc2104cf8e0e Signed-off-by: Julius Werner jwerner@chromium.org --- M util/cbfstool/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37666/1
diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index 95372c2..5c04848 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -129,10 +129,10 @@ TOOLCFLAGS += -mno-ms-bitfields endif ifeq ($(shell uname -o 2>/dev/null), Cygwin) -TOOLCFLAGS+=-std=gnu99 +TOOLCFLAGS+=-std=gnu11 TOOLCPPFLAGS+=-D_GNU_SOURCE else -TOOLCFLAGS+=-std=c99 +TOOLCFLAGS+=-std=c11 endif
$(objutil)/cbfstool/%.o: $(objutil)/cbfstool/%.c
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37666 )
Change subject: cbfstool: Bump C version to C11 ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37666 )
Change subject: cbfstool: Bump C version to C11 ......................................................................
Patch Set 1: Code-Review+1
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37666 )
Change subject: cbfstool: Bump C version to C11 ......................................................................
Patch Set 1:
Looks like this is already breaking stuff for the latest Chromium vboot, so merging it a few hours early.
Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37666 )
Change subject: cbfstool: Bump C version to C11 ......................................................................
cbfstool: Bump C version to C11
cbfstool depends on vboot headers, and vboot expects to be able to use modern C features like _Static_assert(). It just so happens that it doesn't do that in any headers included from cbfstool right now, but that may change. Let's switch cbfstool to a newer version to prevent that from becoming a problem.
Change-Id: I884e1bdf4ec21487ddb1bca57ef5dc2104cf8e0e Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/37666 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M util/cbfstool/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index 95372c2..5c04848 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -129,10 +129,10 @@ TOOLCFLAGS += -mno-ms-bitfields endif ifeq ($(shell uname -o 2>/dev/null), Cygwin) -TOOLCFLAGS+=-std=gnu99 +TOOLCFLAGS+=-std=gnu11 TOOLCPPFLAGS+=-D_GNU_SOURCE else -TOOLCFLAGS+=-std=c99 +TOOLCFLAGS+=-std=c11 endif
$(objutil)/cbfstool/%.o: $(objutil)/cbfstool/%.c
-
Julius Werner (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)