Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31650
Change subject: util/abuild: Set fatal asserts when running scanbuild ......................................................................
util/abuild: Set fatal asserts when running scanbuild
Because coreboot's asserts aren't fatal by default, scan-build finds problems in code that is actually protected by an assert. This change fixes that and allows us to add asserts to protect against other failures.
Change-Id: I9fa605d6309bb40a9cef33b434c9256bf731f457 Signed-off-by: Martin Roth martinroth@google.com --- M util/abuild/abuild 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/31650/1
diff --git a/util/abuild/abuild b/util/abuild/abuild index d32b16d..abfedba 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -675,6 +675,7 @@ scanbuild=true customizing="${customizing}, scan-build" SCANBUILD_ARGS=${SCANBUILD_ARGS:-'-k'} + configoptions="${configoptions}CONFIG_FATAL_ASSERTS=y\n" ;; -y|--ccache) shift customizing="${customizing}, ccache"
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31650 )
Change subject: util/abuild: Set fatal asserts when running scanbuild ......................................................................
Patch Set 1:
Richard, this will help your patches. You can test locally with something like this:
SCANBUILD_ARGS='-k -plist-html -maxloop 10' util/abuild/abuild --scan-build --timeless --blobs --junit --cpus $(nproc) --clean --payloads none --target google/kahlee
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31650 )
Change subject: util/abuild: Set fatal asserts when running scanbuild ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31650 )
Change subject: util/abuild: Set fatal asserts when running scanbuild ......................................................................
util/abuild: Set fatal asserts when running scanbuild
Because coreboot's asserts aren't fatal by default, scan-build finds problems in code that is actually protected by an assert. This change fixes that and allows us to add asserts to protect against other failures.
Change-Id: I9fa605d6309bb40a9cef33b434c9256bf731f457 Signed-off-by: Martin Roth martinroth@google.com Reviewed-on: https://review.coreboot.org/c/31650 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/abuild/abuild 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/util/abuild/abuild b/util/abuild/abuild index d32b16d..abfedba 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -675,6 +675,7 @@ scanbuild=true customizing="${customizing}, scan-build" SCANBUILD_ARGS=${SCANBUILD_ARGS:-'-k'} + configoptions="${configoptions}CONFIG_FATAL_ASSERTS=y\n" ;; -y|--ccache) shift customizing="${customizing}, ccache"
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31650 )
Change subject: util/abuild: Set fatal asserts when running scanbuild ......................................................................
Patch Set 2: Code-Review+1
I don't know this script language, but looks ok to me.
-
Martin Roth (Code Review) -
Patrick Georgi (Code Review)
-
Richard Spiegel (Code Review)