Change in coreboot[master]: mb/google/brya/variants/taeko: Configure GPIOs according to schematics
Attention is currently required from: Joey Peng, Paul Menzel. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56754 )
Change subject: mb/google/brya/variants/taeko: Configure GPIOs according to schematics ......................................................................
Patch Set 7:
(9 comments)
File src/mainboard/google/brya/variants/taeko/gpio.c:
https://review.coreboot.org/c/coreboot/+/56754/comment/5645f788_8c571930 PS7, Line 18: UP_20K `PAD_CFG_GPO` does not take a pullup/pulldown value, should this be:
`PAD_CFG_GPO(GPP_A11, 1, DEEP),`
https://review.coreboot.org/c/coreboot/+/56754/comment/86ce1dcd_7440d3be PS7, Line 38: UP_20K Is the AUD_HP_INT_L on MLB or a DB?
https://review.coreboot.org/c/coreboot/+/56754/comment/d6b8c6f0_84c2b7c3 PS7, Line 45: UP_20K remove
https://review.coreboot.org/c/coreboot/+/56754/comment/671ce90c_7394160b PS7, Line 50: UP_20K remove
https://review.coreboot.org/c/coreboot/+/56754/comment/06ba3221_c24734e7 PS7, Line 59: UP_20K remove
https://review.coreboot.org/c/coreboot/+/56754/comment/3e1ed12c_a51382d0 PS7, Line 63: UP_20K remove
https://review.coreboot.org/c/coreboot/+/56754/comment/11dc7a8b_26ecff75 PS7, Line 81: UP_20K remove
https://review.coreboot.org/c/coreboot/+/56754/comment/42065eb5_1f28b3e7 PS7, Line 90: UP_20K remove
https://review.coreboot.org/c/coreboot/+/56754/comment/210cfa58_1ef72e7c PS7, Line 92: UP_20K remove
-
Tim Wawrzynczak (Code Review)