Change in ...coreboot[master]: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Modul... - coreboot-gerrit

7 Dec 2018


      Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30049 )
Change subject: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Module Part Number
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30049/2/src/mainboard/google/kahlee/variants... 
File src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex:
https://review.coreboot.org/#/c/30049/2/src/mainboard/google/kahlee/variants... 
PS2, Line 23: 00 00
It looks like according to the spec these should both be 20. There's no null terminator in some of the other SPDs, so I think that should be fine.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30049
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d582b3753de9a48865eb6eca7e4fbdb31b799ff
Gerrit-Change-Number: 30049
Gerrit-PatchSet: 2
Gerrit-Owner: Lucas Chen lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Lucas Chen lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Tim Chen tim-chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 07 Dec 2018 20:46:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment