Attention is currently required from: Felix Singer, Karthik Ramasubramanian, Martin L Roth, Raul Rangel.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email )
Change subject: util/crossgcc: Add libstdcxx target
......................................................................
Patch Set 11:
(4 comments)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/85275/comment/de4af8ff_afaad24c?usp... :
PS8, Line 783: declare
`local`?
Done
https://review.coreboot.org/c/coreboot/+/85275/comment/9e35dec8_058fcfc5?usp... :
PS8, Line 784: @
Ack, I was using bash locally. I'll update.
Done
https://review.coreboot.org/c/coreboot/+/85275/comment/c5499c9e_dce488bc?usp... :
PS8, Line 858: [@]
Not an array
Done
https://review.coreboot.org/c/coreboot/+/85275/comment/b3973f96_8428a83a?usp... :
PS8, Line 862: LIBSTDCXX_INCLUDE_PATH
Maybe verify that `LIBSTDCXX_INCLUDE_PATH` isn't empty?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85275?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed
Gerrit-Change-Number: 85275
Gerrit-PatchSet: 11
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sat, 14 Dec 2024 18:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com