Change in coreboot[master]: mb/google/volteer/var/terrador: Update ELAN Touchpad configuration

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

David Wu (Code Review)

16 Jul 2020 16 Jul '20

9:35 a.m.

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43509 )

Change subject: mb/google/volteer/var/terrador: Update ELAN Touchpad configuration ......................................................................

mb/google/volteer/var/terrador: Update ELAN Touchpad configuration

Update ELAN Touchpad configuration

BUG=b:160741785 BRANCH=None TEST=Verify ELAN touchpad is working fine.

Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I098d8a305c6e04af1562a545ff4af6383665798b --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb 1 file changed, 7 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/43509/1

diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb index c1c386a..49d3bad 100644 --- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb +++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb @@ -117,12 +117,13 @@ end end # I2C2 0xA0EA device pci 19.1 on - chip drivers/i2c/generic - register "hid" = ""ELAN0000"" - register "desc" = ""ELAN Touchpad"" - register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_E15_IRQ)" - register "wake" = "GPE0_DW2_15" - register "probed" = "1" + chip drivers/i2c/hid + register "generic.hid" = ""ELAN2700"" + register "generic.desc" = ""ELAN Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E15_IRQ)" + register "generic.wake" = "GPE0_DW2_15" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x01" device i2c 15 on end end end # I2C5 0xA0C6

Attachments:

attachment.htm (text/html — 3.9 KB)

Show replies by date

David Wu (Code Review)

16 Jul 16 Jul

10:06 a.m.

David Wu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/43509 )

Change subject: mb/google/volteer/var/terrador: Update ELAN Touchpad configuration ......................................................................

mb/google/volteer/var/terrador: Update ELAN Touchpad configuration

Update ELAN Touchpad configuration

BUG=b:160741785 BRANCH=None TEST=Verify ELAN touchpad is working fine.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/43509/2

David Wu (Code Review)

11:18 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43509

to look at the new patch set (#3).

Change subject: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad ......................................................................

mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad

Update ELAN i2c-hid touchpad configuration

BUG=b:160741785 BRANCH=None TEST=Verify touchpad is working fine.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/43509/3

David Wu (Code Review)

11:19 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43509

to look at the new patch set (#4).

Change subject: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad ......................................................................

mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad

Update ELAN i2c-hid touchpad configuration

BUG=b:160741785 BRANCH=None TEST=Verify touchpad is working fine.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/43509/4

Caveh Jalali (Code Review)

11:06 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43509 )

Change subject: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43509/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/terrador/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43509/4/src/mainboard/google/voltee... PS4, Line 125: register "generic.probed" = "1" do you need to probe for the trackpad or can you assume it's always present?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I098d8a305c6e04af1562a545ff4af6383665798b Gerrit-Change-Number: 43509 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Dossym Nurmukhanov dossym@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 16 Jul 2020 23:06:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

17 Jul 17 Jul

1:19 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43509 )

Change subject: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43509/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/terrador/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43509/4/src/mainboard/google/voltee... PS4, Line 125: register "generic.probed" = "1"

...

do you need to probe for the trackpad or can you assume it's always present?

If there are plans to multi-source touchpad devices, then "probed" property is required.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I098d8a305c6e04af1562a545ff4af6383665798b Gerrit-Change-Number: 43509 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Dossym Nurmukhanov dossym@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 17 Jul 2020 01:19:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali caveh@chromium.org Gerrit-MessageType: comment

David Wu (Code Review)

18 Jul 18 Jul

1:32 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43509 )

Change subject: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad ......................................................................

Patch Set 4: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43509/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/terrador/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43509/4/src/mainboard/google/voltee... PS4, Line 125: register "generic.probed" = "1"

...

do you need to probe for the trackpad or can you assume it's always present?

We will support multi-source touchpad devices. Thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/43509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I098d8a305c6e04af1562a545ff4af6383665798b Gerrit-Change-Number: 43509 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Dossym Nurmukhanov dossym@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 18 Jul 2020 01:32:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Caveh Jalali caveh@chromium.org Gerrit-MessageType: comment

Caveh Jalali (Code Review)

20 Jul 20 Jul

11:55 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43509 )

Change subject: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I098d8a305c6e04af1562a545ff4af6383665798b Gerrit-Change-Number: 43509 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Dossym Nurmukhanov dossym@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 Jul 2020 23:55:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

26 Jul 26 Jul

9:31 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43509 )

Change subject: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad ......................................................................

mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad

Update ELAN i2c-hid touchpad configuration

BUG=b:160741785 BRANCH=None TEST=Verify touchpad is working fine.

Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I098d8a305c6e04af1562a545ff4af6383665798b Reviewed-on: https://review.coreboot.org/c/coreboot/+/43509 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Caveh Jalali caveh@chromium.org --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb 1 file changed, 7 insertions(+), 6 deletions(-)

Approvals: build bot (Jenkins): Verified David Wu: Looks good to me, but someone else must approve Caveh Jalali: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb index c1c386a..8c0fb38 100644 --- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb +++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb @@ -117,12 +117,13 @@ end end # I2C2 0xA0EA device pci 19.1 on - chip drivers/i2c/generic - register "hid" = ""ELAN0000"" - register "desc" = ""ELAN Touchpad"" - register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_E15_IRQ)" - register "wake" = "GPE0_DW2_15" - register "probed" = "1" + chip drivers/i2c/hid + register "generic.hid" = ""ELAN2700"" + register "generic.desc" = ""ELAN Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_E15_IRQ)" + register "generic.wake" = "GPE0_DW2_15" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x01" device i2c 15 on end end end # I2C5 0xA0C6

-- To view, visit https://review.coreboot.org/c/coreboot/+/43509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I098d8a305c6e04af1562a545ff4af6383665798b Gerrit-Change-Number: 43509 Gerrit-PatchSet: 5 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Dossym Nurmukhanov dossym@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1529

days inactive

1539

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Caveh Jalali (Code Review)
David Wu (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)