Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50850 )
Change subject: util/ectool: Update Makefile ......................................................................
util/ectool: Update Makefile
- Add a help target - Add the -Wshadow and -Werror options - Add a way to disable -Werror
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I0d9fe5beb3a2e103a0bf4603712c3a5ed15f93be Reviewed-on: https://review.coreboot.org/c/coreboot/+/50850 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/ectool/Makefile 1 file changed, 9 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/util/ectool/Makefile b/util/ectool/Makefile index 75504c7..1ef74d2 100644 --- a/util/ectool/Makefile +++ b/util/ectool/Makefile @@ -1,7 +1,8 @@ ## SPDX-License-Identifier: GPL-2.0-only
CC = gcc -CFLAGS = -O2 -Wall -Wextra +WERROR=-Werror +CFLAGS = -O2 -Wall -Wextra -Wshadow $(WERROR) PROGRAM = ectool INSTALL = /usr/bin/env install PREFIX = /usr/local @@ -31,4 +32,10 @@ %.o: %.c $(CC) $(CFLAGS) -c $^ -I. -o $@
-.PHONY: all install clean distclean +help: + @echo "${PROGRAM}: Dump RAM of Embedded Controller (EC)" + @echo "Targets: all, clean, distclean, help, install" + @echo "To disable warnings as errors, run make as:" + @echo " make all WERROR=""" + +.PHONY: all clean distclean help install