Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38492 )
Change subject: mb/google/hatch/var/jinlon: Remove fan control from dptf ......................................................................
mb/google/hatch/var/jinlon: Remove fan control from dptf
Jinlon will use EC to control fan, so remove fan control from dptf.
BUG=b:141259174 TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I8ada4fe72eee260fecf45d00510da8b91e3f10a4 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl 1 file changed, 0 insertions(+), 34 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/38492/1
diff --git a/src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl index 74195e1..ffa7590 100644 --- a/src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl @@ -32,7 +32,6 @@ #define DPTF_TSR1_CRITICAL 105
#define DPTF_ENABLE_CHARGER -#define DPTF_ENABLE_FAN_CONTROL
/* Charger performance states, board-specific values from charger and EC */ Name (CHPS, Package () { @@ -42,39 +41,6 @@ Package () { 0, 0, 0, 0, 8, 0x200, "mA", 0 }, /* 0.5A */ })
-/* DFPS: Fan Performance States */ -Name (DFPS, Package () { - 0, // Revision - /* - * TODO : Need to update this Table after characterization. - * These are initial reference values. - */ - /* Control, Trip Point, Speed, NoiseLevel, Power */ - Package () {90, 0xFFFFFFFF, 6700, 220, 2200}, - Package () {80, 0xFFFFFFFF, 5800, 180, 1800}, - Package () {70, 0xFFFFFFFF, 5000, 145, 1450}, - Package () {67, 0xFFFFFFFF, 4900, 115, 1150}, - Package () {60, 0xFFFFFFFF, 3838, 90, 900}, - Package () {50, 0xFFFFFFFF, 2904, 55, 550}, - Package () {40, 0xFFFFFFFF, 2337, 30, 300}, - Package () {20, 0xFFFFFFFF, 1608, 15, 150}, - Package () {10, 0xFFFFFFFF, 800, 10, 100}, - Package () {0, 0xFFFFFFFF, 0, 0, 50} -}) - -Name (DART, Package () { - /* Fan effect on CPU */ - 0, // Revision - Package () { - /* - * Source, Target, Weight, AC0, AC1, AC2, AC3, AC4, AC5, AC6, - * AC7, AC8, AC9 - */ - _SB.DPTF.TFN1, _SB.PCI0.TCPU, 100, 70, 67, 60, 50, 40, 0, 0, - 0, 0, 0 - }, -}) - Name (DTRT, Package () { /* CPU Throttle Effect on CPU */ Package () { _SB.PCI0.TCPU, _SB.PCI0.TCPU, 100, 50, 0, 0, 0, 0 },
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38492 )
Change subject: mb/google/hatch/var/jinlon: Remove fan control from dptf ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38492/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38492/1//COMMIT_MSG@7 PS1, Line 7: Remove fan control from dptf This sentence sounds a bit weird. Instead, I would use:
Remove DPTF fan control
Note that, just like "EC", "DPTF" is also an acronym, so it should be in uppercase.
Hello Paul Fagerburg, Angel Pons, Philip Chen, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38492
to look at the new patch set (#2).
Change subject: mb/google/hatch/var/jinlon: Remove DPTF fan control ......................................................................
mb/google/hatch/var/jinlon: Remove DPTF fan control
Jinlon will use EC to control fan, so remove fan control from dptf.
BUG=b:141259174 TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I8ada4fe72eee260fecf45d00510da8b91e3f10a4 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl 1 file changed, 0 insertions(+), 34 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/38492/2
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38492 )
Change subject: mb/google/hatch/var/jinlon: Remove DPTF fan control ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38492/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38492/1//COMMIT_MSG@7 PS1, Line 7: Remove fan control from dptf
This sentence sounds a bit weird. Instead, I would use: […]
Done
Hello Paul Fagerburg, Angel Pons, Philip Chen, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38492
to look at the new patch set (#3).
Change subject: mb/google/hatch/var/jinlon: Remove DPTF fan control ......................................................................
mb/google/hatch/var/jinlon: Remove DPTF fan control
Jinlon will use EC to control fan, so remove DPTF fan control.
BUG=b:141259174 TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I8ada4fe72eee260fecf45d00510da8b91e3f10a4 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl 1 file changed, 0 insertions(+), 34 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/38492/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38492 )
Change subject: mb/google/hatch/var/jinlon: Remove DPTF fan control ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38492/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38492/1//COMMIT_MSG@7 PS1, Line 7: Remove fan control from dptf
Done
Thanks :)
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38492 )
Change subject: mb/google/hatch/var/jinlon: Remove DPTF fan control ......................................................................
mb/google/hatch/var/jinlon: Remove DPTF fan control
Jinlon will use EC to control fan, so remove DPTF fan control.
BUG=b:141259174 TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I8ada4fe72eee260fecf45d00510da8b91e3f10a4 Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38492 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl 1 file changed, 0 insertions(+), 34 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl index 74195e1..ffa7590 100644 --- a/src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/jinlon/include/variant/acpi/dptf.asl @@ -32,7 +32,6 @@ #define DPTF_TSR1_CRITICAL 105
#define DPTF_ENABLE_CHARGER -#define DPTF_ENABLE_FAN_CONTROL
/* Charger performance states, board-specific values from charger and EC */ Name (CHPS, Package () { @@ -42,39 +41,6 @@ Package () { 0, 0, 0, 0, 8, 0x200, "mA", 0 }, /* 0.5A */ })
-/* DFPS: Fan Performance States */ -Name (DFPS, Package () { - 0, // Revision - /* - * TODO : Need to update this Table after characterization. - * These are initial reference values. - */ - /* Control, Trip Point, Speed, NoiseLevel, Power */ - Package () {90, 0xFFFFFFFF, 6700, 220, 2200}, - Package () {80, 0xFFFFFFFF, 5800, 180, 1800}, - Package () {70, 0xFFFFFFFF, 5000, 145, 1450}, - Package () {67, 0xFFFFFFFF, 4900, 115, 1150}, - Package () {60, 0xFFFFFFFF, 3838, 90, 900}, - Package () {50, 0xFFFFFFFF, 2904, 55, 550}, - Package () {40, 0xFFFFFFFF, 2337, 30, 300}, - Package () {20, 0xFFFFFFFF, 1608, 15, 150}, - Package () {10, 0xFFFFFFFF, 800, 10, 100}, - Package () {0, 0xFFFFFFFF, 0, 0, 50} -}) - -Name (DART, Package () { - /* Fan effect on CPU */ - 0, // Revision - Package () { - /* - * Source, Target, Weight, AC0, AC1, AC2, AC3, AC4, AC5, AC6, - * AC7, AC8, AC9 - */ - _SB.DPTF.TFN1, _SB.PCI0.TCPU, 100, 70, 67, 60, 50, 40, 0, 0, - 0, 0, 0 - }, -}) - Name (DTRT, Package () { /* CPU Throttle Effect on CPU */ Package () { _SB.PCI0.TCPU, _SB.PCI0.TCPU, 100, 50, 0, 0, 0, 0 },
-
Angel Pons (Code Review) -
Chen Wisley (Code Review)
-
Patrick Georgi (Code Review)