Attention is currently required from: Angel Pons, Dinesh Gehlot, Julius Werner, Paul Menzel.
Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83705?usp=email )
Change subject: vc/google/chromeos: Enable eSOL config with libgfx and uGOP ......................................................................
Patch Set 23:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83705/comment/f1f82bcc_0518144a?usp... : PS20, Line 15: Cq-Depend: CB:83769, CB:83770
This is a thing specific to the ChromeOS CI, it does not work here. […]
Understood, removed. Thanks
https://review.coreboot.org/c/coreboot/+/83705/comment/3df067d6_7f949e90?usp... : PS20, Line 15: Cq-Depend: CB:83769, CB:83770
please remove this. […]
Removed, thanks.
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/83705/comment/21546af8_9d427522?usp... : PS20, Line 105: config CHROMEOS_ENABLE_ESOL
Does this Kconfig actually do anything? I don't see it referenced anywhere? […]
As Subrata mentioned, b/352651132 provides some context for the change. Added the bug in the commit message as well.
Thanks