Attention is currently required from: Idwer Vollering.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56677 )
Change subject: util/kconfig: detect ncurses on FreeBSD
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
Martin, why did you submit it? Should I have given -1 to prevent premature submission. […]
It’s not a big deal, as it can be easily reverted/improved, but as the long term goal is to reduce our Kconfig differences in regards to Kconfig upstream, it would be great to have a proper analysis on the failure (and a elaborate description in the patch files in the directory `patches/`. Right now, that would fall on the people wanting to upstream the changes making it even harder.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e
Gerrit-Change-Number: 56677
Gerrit-PatchSet: 6
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Comment-Date: Sat, 07 Aug 2021 09:03:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment