HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43362 )
Change subject: src: Remove unused 'include <cbmem.h>' ......................................................................
src: Remove unused 'include <cbmem.h>'
Change-Id: Ib41341b42904dc3050a97b70966dde7e46057d6b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/amd/agesa/state_machine.c M src/ec/google/chromeec/ec.c M src/lib/imd.c M src/mainboard/emulation/qemu-aarch64/mainboard.c M src/security/vboot/bootmode.c M src/security/vboot/vboot_common.c M src/security/vboot/vboot_logic.c M src/soc/amd/common/block/pi/refcode_loader.c M src/soc/amd/picasso/mca.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/baytrail/refcode.c M src/soc/intel/broadwell/refcode.c M src/soc/intel/cannonlake/elog.c M src/soc/intel/denverton_ns/romstage.c M src/soc/intel/icelake/elog.c M src/soc/intel/jasperlake/elog.c M src/soc/intel/tigerlake/elog.c M src/soc/intel/xeon_sp/skx/romstage.c M src/southbridge/amd/cimx/sb800/ramtop.c 20 files changed, 1 insertion(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/43362/1
diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c index 6ae7d99..606a66f 100644 --- a/src/drivers/amd/agesa/state_machine.c +++ b/src/drivers/amd/agesa/state_machine.c @@ -5,7 +5,6 @@ #include <acpi/acpi.h> #include <bootstate.h> #include <cbfs.h> -#include <cbmem.h> #include <timestamp.h>
#include <northbridge/amd/agesa/state_machine.h> diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index a97dfb3..2855b64 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -3,7 +3,6 @@ #include <stdint.h> #include <string.h> #include <assert.h> -#include <cbmem.h> #include <console/console.h> #include <delay.h> #include <device/device.h> diff --git a/src/lib/imd.c b/src/lib/imd.c index c87037d..d1f37fe 100644 --- a/src/lib/imd.c +++ b/src/lib/imd.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> -#include <cbmem.h> #include <console/console.h> #include <imd.h> #include <stdlib.h> diff --git a/src/mainboard/emulation/qemu-aarch64/mainboard.c b/src/mainboard/emulation/qemu-aarch64/mainboard.c index e6da3a6..7bf9260 100644 --- a/src/mainboard/emulation/qemu-aarch64/mainboard.c +++ b/src/mainboard/emulation/qemu-aarch64/mainboard.c @@ -1,10 +1,5 @@ -/* - * - * - * SPDX-License-Identifier: GPL-2.0-or-later - */ +/* SPDX-License-Identifier: GPL-2.0-or-later */
-#include <cbmem.h> #include <ramdetect.h> #include <symbols.h> #include <device/device.h> diff --git a/src/security/vboot/bootmode.c b/src/security/vboot/bootmode.c index 5bd3922..4f491db 100644 --- a/src/security/vboot/bootmode.c +++ b/src/security/vboot/bootmode.c @@ -3,7 +3,6 @@ #include <assert.h> #include <bootmode.h> #include <bootstate.h> -#include <cbmem.h> #include <vb2_api.h> #include <security/vboot/misc.h> #include <security/vboot/vbnv.h> diff --git a/src/security/vboot/vboot_common.c b/src/security/vboot/vboot_common.c index 1cddeeb..215e209 100644 --- a/src/security/vboot/vboot_common.c +++ b/src/security/vboot/vboot_common.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <boot_device.h> -#include <cbmem.h> #include <console/cbmem_console.h> #include <reset.h> #include <security/vboot/misc.h> diff --git a/src/security/vboot/vboot_logic.c b/src/security/vboot/vboot_logic.c index e23dcc4..c4c3b4b 100644 --- a/src/security/vboot/vboot_logic.c +++ b/src/security/vboot/vboot_logic.c @@ -3,7 +3,6 @@ #include <arch/exception.h> #include <assert.h> #include <bootmode.h> -#include <cbmem.h> #include <fmap.h> #include <security/tpm/tspi/crtm.h> #include <security/tpm/tss/vendor/cr50/cr50.h> diff --git a/src/soc/amd/common/block/pi/refcode_loader.c b/src/soc/amd/common/block/pi/refcode_loader.c index 2fdbe83..821a9b0 100644 --- a/src/soc/amd/common/block/pi/refcode_loader.c +++ b/src/soc/amd/common/block/pi/refcode_loader.c @@ -2,7 +2,6 @@
#include <acpi/acpi.h> #include <cbfs.h> -#include <cbmem.h> #include <console/console.h> #include <rmodule.h> #include <stage_cache.h> diff --git a/src/soc/amd/picasso/mca.c b/src/soc/amd/picasso/mca.c index 69363f5..e16d0a1 100644 --- a/src/soc/amd/picasso/mca.c +++ b/src/soc/amd/picasso/mca.c @@ -7,7 +7,6 @@ #include <console/console.h> #include <arch/bert_storage.h> #include <cper.h> -#include <cbmem.h>
struct mca_bank { int bank; diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c index 6855bf6..4df8cdb 100644 --- a/src/soc/amd/picasso/romstage.c +++ b/src/soc/amd/picasso/romstage.c @@ -5,7 +5,6 @@ #include <cpu/x86/cache.h> #include <cpu/amd/mtrr.h> #include <console/uart.h> -#include <cbmem.h> #include <commonlib/helpers.h> #include <console/console.h> #include <program_loading.h> diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index d14dd8d..c5b060f 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -4,7 +4,6 @@ #include <device/pci_ops.h> #include <arch/symbols.h> #include <assert.h> -#include <cbmem.h> #include <cf9_reset.h> #include <console/console.h> #include <cpu/x86/pae.h> diff --git a/src/soc/intel/baytrail/refcode.c b/src/soc/intel/baytrail/refcode.c index 297ed9c..eafbc15 100644 --- a/src/soc/intel/baytrail/refcode.c +++ b/src/soc/intel/baytrail/refcode.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <acpi/acpi.h> -#include <cbmem.h> #include <console/console.h> #include <console/streams.h> #include <cpu/x86/tsc.h> diff --git a/src/soc/intel/broadwell/refcode.c b/src/soc/intel/broadwell/refcode.c index 882f888..26352bb 100644 --- a/src/soc/intel/broadwell/refcode.c +++ b/src/soc/intel/broadwell/refcode.c @@ -2,7 +2,6 @@
#include <string.h> #include <acpi/acpi.h> -#include <cbmem.h> #include <console/console.h> #include <console/streams.h> #include <program_loading.h> diff --git a/src/soc/intel/cannonlake/elog.c b/src/soc/intel/cannonlake/elog.c index fb25472..9fa725e 100644 --- a/src/soc/intel/cannonlake/elog.c +++ b/src/soc/intel/cannonlake/elog.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <cbmem.h> #include <console/console.h> #include <device/pci_ops.h> #include <stdint.h> diff --git a/src/soc/intel/denverton_ns/romstage.c b/src/soc/intel/denverton_ns/romstage.c index 713fb1e..add558b 100644 --- a/src/soc/intel/denverton_ns/romstage.c +++ b/src/soc/intel/denverton_ns/romstage.c @@ -2,7 +2,6 @@
#include <arch/romstage.h> #include <arch/io.h> -#include <cbmem.h> #include <cf9_reset.h> #include <console/console.h> #include <device/pci_ops.h> diff --git a/src/soc/intel/icelake/elog.c b/src/soc/intel/icelake/elog.c index 586dbfd..4727fbf 100644 --- a/src/soc/intel/icelake/elog.c +++ b/src/soc/intel/icelake/elog.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <cbmem.h> #include <console/console.h> #include <stdint.h> #include <elog.h> diff --git a/src/soc/intel/jasperlake/elog.c b/src/soc/intel/jasperlake/elog.c index 586dbfd..4727fbf 100644 --- a/src/soc/intel/jasperlake/elog.c +++ b/src/soc/intel/jasperlake/elog.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <cbmem.h> #include <console/console.h> #include <stdint.h> #include <elog.h> diff --git a/src/soc/intel/tigerlake/elog.c b/src/soc/intel/tigerlake/elog.c index d5b8754..b38d316 100644 --- a/src/soc/intel/tigerlake/elog.c +++ b/src/soc/intel/tigerlake/elog.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <cbmem.h> #include <console/console.h> #include <stdint.h> #include <elog.h> diff --git a/src/soc/intel/xeon_sp/skx/romstage.c b/src/soc/intel/xeon_sp/skx/romstage.c index c4c473b..a1c370d 100644 --- a/src/soc/intel/xeon_sp/skx/romstage.c +++ b/src/soc/intel/xeon_sp/skx/romstage.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <arch/romstage.h> -#include <cbmem.h> #include <console/console.h> #include <intelblocks/rtc.h> #include <soc/romstage.h> diff --git a/src/southbridge/amd/cimx/sb800/ramtop.c b/src/southbridge/amd/cimx/sb800/ramtop.c index 5dac9ae..483716c 100644 --- a/src/southbridge/amd/cimx/sb800/ramtop.c +++ b/src/southbridge/amd/cimx/sb800/ramtop.c @@ -3,7 +3,6 @@ #include <stdint.h> #include <arch/io.h> #include <acpi/acpi.h> -#include <cbmem.h> #include "SBPLATFORM.h"
int acpi_get_sleep_type(void)
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Andrey Petrov, Patrick Rudolph, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43362
to look at the new patch set (#2).
Change subject: src: Remove unused 'include <cbmem.h>' ......................................................................
src: Remove unused 'include <cbmem.h>'
Change-Id: Ib41341b42904dc3050a97b70966dde7e46057d6b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/amd/agesa/state_machine.c M src/ec/google/chromeec/ec.c M src/mainboard/emulation/qemu-aarch64/mainboard.c M src/security/vboot/bootmode.c M src/security/vboot/vboot_common.c M src/security/vboot/vboot_logic.c M src/soc/amd/common/block/pi/refcode_loader.c M src/soc/amd/picasso/mca.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/baytrail/refcode.c M src/soc/intel/broadwell/refcode.c M src/soc/intel/cannonlake/elog.c M src/soc/intel/denverton_ns/romstage.c M src/soc/intel/icelake/elog.c M src/soc/intel/jasperlake/elog.c M src/soc/intel/tigerlake/elog.c M src/soc/intel/xeon_sp/skx/romstage.c M src/southbridge/amd/cimx/sb800/ramtop.c 19 files changed, 1 insertion(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/43362/2
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Andrey Petrov, Patrick Rudolph, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43362
to look at the new patch set (#3).
Change subject: src: Remove unused 'include <cbmem.h>' ......................................................................
src: Remove unused 'include <cbmem.h>'
Change-Id: Ib41341b42904dc3050a97b70966dde7e46057d6b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/amd/agesa/state_machine.c M src/ec/google/chromeec/ec.c M src/mainboard/emulation/qemu-aarch64/mainboard.c M src/security/vboot/bootmode.c M src/security/vboot/vboot_common.c M src/security/vboot/vboot_logic.c M src/soc/amd/picasso/mca.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/cannonlake/elog.c M src/soc/intel/denverton_ns/romstage.c M src/soc/intel/icelake/elog.c M src/soc/intel/jasperlake/elog.c M src/soc/intel/tigerlake/elog.c M src/soc/intel/xeon_sp/skx/romstage.c M src/southbridge/amd/cimx/sb800/ramtop.c 16 files changed, 1 insertion(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/43362/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43362 )
Change subject: src: Remove unused 'include <cbmem.h>' ......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43362/7/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-aarch64/mainboard.c:
PS7: woups
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43362 )
Change subject: src: Remove unused 'include <cbmem.h>' ......................................................................
src: Remove unused 'include <cbmem.h>'
Change-Id: Ib41341b42904dc3050a97b70966dde7e46057d6b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43362 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/amd/agesa/state_machine.c M src/ec/google/chromeec/ec.c M src/mainboard/emulation/qemu-aarch64/mainboard.c M src/security/vboot/bootmode.c M src/security/vboot/vboot_common.c M src/security/vboot/vboot_logic.c M src/soc/amd/picasso/mca.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/cannonlake/elog.c M src/soc/intel/denverton_ns/romstage.c M src/soc/intel/icelake/elog.c M src/soc/intel/jasperlake/elog.c M src/soc/intel/tigerlake/elog.c M src/soc/intel/xeon_sp/skx/romstage.c M src/southbridge/amd/cimx/sb800/ramtop.c 16 files changed, 0 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c index 6ae7d99..606a66f 100644 --- a/src/drivers/amd/agesa/state_machine.c +++ b/src/drivers/amd/agesa/state_machine.c @@ -5,7 +5,6 @@ #include <acpi/acpi.h> #include <bootstate.h> #include <cbfs.h> -#include <cbmem.h> #include <timestamp.h>
#include <northbridge/amd/agesa/state_machine.h> diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 954e649..e66e3b1 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -3,7 +3,6 @@ #include <stdint.h> #include <string.h> #include <assert.h> -#include <cbmem.h> #include <console/console.h> #include <delay.h> #include <device/device.h> diff --git a/src/mainboard/emulation/qemu-aarch64/mainboard.c b/src/mainboard/emulation/qemu-aarch64/mainboard.c index d43eb89..7bf9260 100644 --- a/src/mainboard/emulation/qemu-aarch64/mainboard.c +++ b/src/mainboard/emulation/qemu-aarch64/mainboard.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-#include <cbmem.h> #include <ramdetect.h> #include <symbols.h> #include <device/device.h> diff --git a/src/security/vboot/bootmode.c b/src/security/vboot/bootmode.c index 5bd3922..4f491db 100644 --- a/src/security/vboot/bootmode.c +++ b/src/security/vboot/bootmode.c @@ -3,7 +3,6 @@ #include <assert.h> #include <bootmode.h> #include <bootstate.h> -#include <cbmem.h> #include <vb2_api.h> #include <security/vboot/misc.h> #include <security/vboot/vbnv.h> diff --git a/src/security/vboot/vboot_common.c b/src/security/vboot/vboot_common.c index 1cddeeb..215e209 100644 --- a/src/security/vboot/vboot_common.c +++ b/src/security/vboot/vboot_common.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <boot_device.h> -#include <cbmem.h> #include <console/cbmem_console.h> #include <reset.h> #include <security/vboot/misc.h> diff --git a/src/security/vboot/vboot_logic.c b/src/security/vboot/vboot_logic.c index e23dcc4..c4c3b4b 100644 --- a/src/security/vboot/vboot_logic.c +++ b/src/security/vboot/vboot_logic.c @@ -3,7 +3,6 @@ #include <arch/exception.h> #include <assert.h> #include <bootmode.h> -#include <cbmem.h> #include <fmap.h> #include <security/tpm/tspi/crtm.h> #include <security/tpm/tss/vendor/cr50/cr50.h> diff --git a/src/soc/amd/picasso/mca.c b/src/soc/amd/picasso/mca.c index 69363f5..e16d0a1 100644 --- a/src/soc/amd/picasso/mca.c +++ b/src/soc/amd/picasso/mca.c @@ -7,7 +7,6 @@ #include <console/console.h> #include <arch/bert_storage.h> #include <cper.h> -#include <cbmem.h>
struct mca_bank { int bank; diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c index 0a337e7..372c6b5 100644 --- a/src/soc/amd/picasso/romstage.c +++ b/src/soc/amd/picasso/romstage.c @@ -5,7 +5,6 @@ #include <cpu/x86/cache.h> #include <cpu/amd/mtrr.h> #include <console/uart.h> -#include <cbmem.h> #include <commonlib/helpers.h> #include <console/console.h> #include <program_loading.h> diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index d14dd8d..c5b060f 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -4,7 +4,6 @@ #include <device/pci_ops.h> #include <arch/symbols.h> #include <assert.h> -#include <cbmem.h> #include <cf9_reset.h> #include <console/console.h> #include <cpu/x86/pae.h> diff --git a/src/soc/intel/cannonlake/elog.c b/src/soc/intel/cannonlake/elog.c index fb25472..9fa725e 100644 --- a/src/soc/intel/cannonlake/elog.c +++ b/src/soc/intel/cannonlake/elog.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <cbmem.h> #include <console/console.h> #include <device/pci_ops.h> #include <stdint.h> diff --git a/src/soc/intel/denverton_ns/romstage.c b/src/soc/intel/denverton_ns/romstage.c index 713fb1e..add558b 100644 --- a/src/soc/intel/denverton_ns/romstage.c +++ b/src/soc/intel/denverton_ns/romstage.c @@ -2,7 +2,6 @@
#include <arch/romstage.h> #include <arch/io.h> -#include <cbmem.h> #include <cf9_reset.h> #include <console/console.h> #include <device/pci_ops.h> diff --git a/src/soc/intel/icelake/elog.c b/src/soc/intel/icelake/elog.c index 586dbfd..4727fbf 100644 --- a/src/soc/intel/icelake/elog.c +++ b/src/soc/intel/icelake/elog.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <cbmem.h> #include <console/console.h> #include <stdint.h> #include <elog.h> diff --git a/src/soc/intel/jasperlake/elog.c b/src/soc/intel/jasperlake/elog.c index 586dbfd..4727fbf 100644 --- a/src/soc/intel/jasperlake/elog.c +++ b/src/soc/intel/jasperlake/elog.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <cbmem.h> #include <console/console.h> #include <stdint.h> #include <elog.h> diff --git a/src/soc/intel/tigerlake/elog.c b/src/soc/intel/tigerlake/elog.c index d5b8754..b38d316 100644 --- a/src/soc/intel/tigerlake/elog.c +++ b/src/soc/intel/tigerlake/elog.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h> -#include <cbmem.h> #include <console/console.h> #include <stdint.h> #include <elog.h> diff --git a/src/soc/intel/xeon_sp/skx/romstage.c b/src/soc/intel/xeon_sp/skx/romstage.c index c4c473b..a1c370d 100644 --- a/src/soc/intel/xeon_sp/skx/romstage.c +++ b/src/soc/intel/xeon_sp/skx/romstage.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <arch/romstage.h> -#include <cbmem.h> #include <console/console.h> #include <intelblocks/rtc.h> #include <soc/romstage.h> diff --git a/src/southbridge/amd/cimx/sb800/ramtop.c b/src/southbridge/amd/cimx/sb800/ramtop.c index 5dac9ae..483716c 100644 --- a/src/southbridge/amd/cimx/sb800/ramtop.c +++ b/src/southbridge/amd/cimx/sb800/ramtop.c @@ -3,7 +3,6 @@ #include <stdint.h> #include <arch/io.h> #include <acpi/acpi.h> -#include <cbmem.h> #include "SBPLATFORM.h"
int acpi_get_sleep_type(void)
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)