Change in coreboot[master]: mb/google/voteer: Enable DevSlp for SATA port1

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Wonkyu Kim (Code Review)

21 Apr 2020 21 Apr '20

9:22 p.m.

Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40584 )

Change subject: mb/google/voteer: Enable DevSlp for SATA port1 ......................................................................

mb/google/voteer: Enable DevSlp for SATA port1

BUG=b:152893285 BRANCH=none TEST=Build and boot to OS volteer with Intel SATA and reboot from OS console

Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: Ibed8f8c445bf2ac2290ffb670d8dfb83fc960438 --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/40584/1

diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 28931e4..88e4247 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -77,6 +77,7 @@ register "SataPortsEnable[0]" = "0" register "SataPortsEnable[1]" = "1" register "SataPortsDevSlp[0]" = "0" + register "SataPortsDevSlp[1]" = "1"

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Wonkyu Kim (Code Review)

21 Apr 21 Apr

11:58 p.m.

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40584 )

Change subject: mb/google/voteer: Enable DevSlp for SATA port1 ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/40584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibed8f8c445bf2ac2290ffb670d8dfb83fc960438 Gerrit-Change-Number: 40584 Gerrit-PatchSet: 1 Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: Alex Levin levinale@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Ravishankar Sarawadi ravishankar.sarawadi@intel.com Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 22 Apr 2020 02:58:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

22 Apr 22 Apr

6:49 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40584 )

Change subject: mb/google/voteer: Enable DevSlp for SATA port1 ......................................................................

Patch Set 1: Code-Review+2

We also need to be able to set SataPortsDevSlpResetConfig to PLTRST.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibed8f8c445bf2ac2290ffb670d8dfb83fc960438 Gerrit-Change-Number: 40584 Gerrit-PatchSet: 1 Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: Alex Levin levinale@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Ravishankar Sarawadi ravishankar.sarawadi@intel.com Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 22 Apr 2020 21:49:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

30 Apr 30 Apr

1:35 p.m.

Duncan Laurie has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40584 )

Change subject: mb/google/voteer: Enable DevSlp for SATA port1 ......................................................................

mb/google/voteer: Enable DevSlp for SATA port1

BUG=b:152893285 BRANCH=none TEST=Build and boot to OS volteer with Intel SATA and reboot from OS console

Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: Ibed8f8c445bf2ac2290ffb670d8dfb83fc960438 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40584 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Wonkyu Kim: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 12ae87a..b689663 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -77,6 +77,7 @@ register "SataPortsEnable[0]" = "0" register "SataPortsEnable[1]" = "1" register "SataPortsDevSlp[0]" = "0" + register "SataPortsDevSlp[1]" = "1"

-- To view, visit https://review.coreboot.org/c/coreboot/+/40584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibed8f8c445bf2ac2290ffb670d8dfb83fc960438 Gerrit-Change-Number: 40584 Gerrit-PatchSet: 2 Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: Alex Levin levinale@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ravishankar Sarawadi ravishankar.sarawadi@intel.com Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

1 May 1 May

12:15 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40584 )

Change subject: mb/google/voteer: Enable DevSlp for SATA port1 ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2940 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2939 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2938 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2937

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibed8f8c445bf2ac2290ffb670d8dfb83fc960438 Gerrit-Change-Number: 40584 Gerrit-PatchSet: 2 Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: Alex Levin levinale@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ravishankar Sarawadi ravishankar.sarawadi@intel.com Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com Gerrit-Reviewer: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 01 May 2020 15:15:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1508

days inactive

1517

days old

coreboot-gerrit@coreboot.org

4 comments

3 participants

tags (0)

participants (3)

9elements QA (Code Review)
Duncan Laurie (Code Review)
Wonkyu Kim (Code Review)