Change in coreboot[master]: mb/google/puff: add a region to cache SPD data

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40415 )

Change subject: mb/google/puff: add a region to cache SPD data
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40415/5/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/romstage_spd_smbus.c:

https://review.coreboot.org/c/coreboot/+/40415/5/src/mainboard/google/hatch/... 
PS5, Line 47: 		if (need_update_cache)
If dimm_changed, we need update cache anyway, right? Any condition will be dimm_changed but doesn't need update cache?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40415
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d07fddf113a767d62394cb31e33b56f22f74351
Gerrit-Change-Number: 40415
Gerrit-PatchSet: 5
Gerrit-Owner: Jamie Chen <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Furquan Shaikh <[e-mail]>
Gerrit-Reviewer: Kane Chen <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-CC: Arthur Heymans <[e-mail]>
Gerrit-CC: EricR Lai <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Mon, 04 May 2020 15:13:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment