Attention is currently required from: Shobhit Srivastava, Subrata Banik, Maulik V Vaghela, Sridhar Siricilla, Kane Chen. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62861 )
Change subject: soc/intel/adl: Remove IOM Mctp command from TCSS ASL ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62861/comment/8a286093_53acc0b0 PS2, Line 14: Due to change in hardware sequence maybe mention like `We discovered that due to a change in the hardware sequence...`
https://review.coreboot.org/c/coreboot/+/62861/comment/7a9ee1b5_a66616e9 PS2, Line 26: MAULIK V VAGHELA is your name in git config still set to all caps? 😄
File src/soc/intel/alderlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/62861/comment/8c2e038a_faa6aa3f PS2, Line 694: /* : * If the TCSS Deven is cleared by BIOS Mailbox request, then : * restore to previously saved value of TCSS DEVNE. : */ : Local0 = 0 : While (_SB.PCI0.TXHC.VDID == 0xFFFFFFFF) { : If (DSGS () == 1) { : DSCR (0) : } : Local0++ : If (Local0 == 5) { : Printf("pCode mailbox command failed.") : Break : } : } Is this part still necessary too? I don't see the reference code doing this.
https://review.coreboot.org/c/coreboot/+/62861/comment/e7e82603_d0feb82d PS2, Line 725: /* : * If the TCSS Deven in normal state, then Save current TCSS DEVEN value and : * clear it. : */ : Local0 = 0 : While (_SB.PCI0.TXHC.VDID != 0xFFFFFFFF) { : If (DSGS () == 0) { : DSCR (1) : } : Local0++ : If (Local0 == 5) { : Printf("pCode mailbox command failed.") : Break : } : } Is this part still necessary too? I don't see the reference code doing this.
-
Tim Wawrzynczak (Code Review)