Alexandru Gagniuc (mr.nuke.me@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4824
-gerrit
commit fc5c761656a4821430cbb161253b62fe7482e77b Author: Vladimir Serbinenko phcoder@gmail.com Date: Sun Jan 26 20:25:49 2014 +0100
mc146818rtc: Disable read_option on non-romcc code
YOU SHALL NOT COMMIT!
, _,- (\ _,-',' \ ,-" ,' \ ,' ,' \ _:.----__.-."-._,-._ \ .-".:--`:::::.:.:' ) `-. \ `. ::L .::::::'`-._ ( ) : \ ":::::::' `-. `-_ ) ,' \.._/_`:::,' `. . `-: :" _ """ `-_ . ` `. "\"":--\ `-.__ ` . `. \':: \ _-"__`--.__ ` . `. _,--..- \ :: _-":)( ""-._ ` `.-'' \`:`-":::/ \ . . `-. : :\:::::::' \ ` . `. : :\:':':' . \ `, : : : \ . \ . `. : ,- __`:\ . \ . ` ,' ,: : ,-' _,---"" : \ ' \ . :-" ,' ,-"" : \: . : \ ` ' ,' / ' : : \ . \ . _,' ,-' : . ' : :` `,-' ,--' : : : ,'-._,' ,-' _: : :8: ,--' :dd`-._,'-._.__-""' ,' ,----' _.----' __..--"" ""
Change-Id: I903aab9490bd405b0dbbbe23d2ef1db29845392b Signed-off-by: Vladimir Serbinenko phcoder@gmail.com --- src/include/pc80/mc146818rtc.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h index fd40308..11aed88 100644 --- a/src/include/pc80/mc146818rtc.h +++ b/src/include/pc80/mc146818rtc.h @@ -188,8 +188,12 @@ static inline enum cb_err get_option(void *dest __attribute__((unused)), #else #include <drivers/pc80/mc146818rtc_early.c> #endif + +#if defined(__ROMCC__) #define read_option(name, default) read_option_lowlevel(CMOS_VSTART_ ##name, CMOS_VLEN_ ##name, (default)) +#endif
+#if defined(__ROMCC__) #if CONFIG_CMOS_POST #if CONFIG_USE_OPTION_TABLE # include "option_table.h" @@ -201,6 +205,7 @@ static inline enum cb_err get_option(void *dest __attribute__((unused)), # error "Must define CONFIG_CMOS_POST_OFFSET" # endif #endif +#endif
/* * 0 = Bank Select Magic