HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46171 )
Change subject: mb/google/butterfly: Convert to ASL 2.0 syntax ......................................................................
mb/google/butterfly: Convert to ASL 2.0 syntax
Change-Id: I85edf649a5170a1658fb135b797c1c6e1d2a9d70 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/butterfly/acpi/mainboard.asl M src/mainboard/google/butterfly/acpi/platform.asl M src/mainboard/google/butterfly/acpi/thermal.asl 3 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46171/1
diff --git a/src/mainboard/google/butterfly/acpi/mainboard.asl b/src/mainboard/google/butterfly/acpi/mainboard.asl index 02ef905..3552e29 100644 --- a/src/mainboard/google/butterfly/acpi/mainboard.asl +++ b/src/mainboard/google/butterfly/acpi/mainboard.asl @@ -8,7 +8,7 @@ Name (_HID, EisaId("PNP0C0D")) Method (_LID, 0) { - Store (_SB.PCI0.LPCB.EC0.LIDF, \LIDS) + \LIDS = _SB.PCI0.LPCB.EC0.LIDF Return (\LIDS) } } diff --git a/src/mainboard/google/butterfly/acpi/platform.asl b/src/mainboard/google/butterfly/acpi/platform.asl index f59e485..7c8a815 100644 --- a/src/mainboard/google/butterfly/acpi/platform.asl +++ b/src/mainboard/google/butterfly/acpi/platform.asl @@ -15,16 +15,16 @@ { /* Update in case state changed while asleep */ /* Update AC status */ - Store (_SB.PCI0.LPCB.EC0.ADPT, Local0) - if (LNotEqual (Local0, \PWRS)) { - Store (Local0, \PWRS) + Local0 = _SB.PCI0.LPCB.EC0.ADPT + if (Local0 != \PWRS) { + \PWRS = Local0 Notify (_SB.PCI0.LPCB.EC0.AC, 0x80) }
/* Update LID status */ - Store (_SB.PCI0.LPCB.EC0.LIDF, Local0) - if (LNotEqual (Local0, \LIDS)) { - Store (Local0, \LIDS) + Local0 = _SB.PCI0.LPCB.EC0.LIDF + if (Local0 != \LIDS) { + \LIDS = Local0 Notify (_SB.LID0, 0x80) }
diff --git a/src/mainboard/google/butterfly/acpi/thermal.asl b/src/mainboard/google/butterfly/acpi/thermal.asl index 4c6f6d9..ed381cd 100644 --- a/src/mainboard/google/butterfly/acpi/thermal.asl +++ b/src/mainboard/google/butterfly/acpi/thermal.asl @@ -21,10 +21,10 @@ // Convert from Degrees C to 1/10 Kelvin for ACPI Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10
// Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) } @@ -50,13 +50,13 @@ Method (_TMP, 0, Serialized) { // Get CPU Temperature from EC - Store (_SB.PCI0.LPCB.EC0.CTMP, Local0) + Local0 = _SB.PCI0.LPCB.EC0.CTMP
// Convert to 1/10 Kelvin - Multiply (Local0, 10, Local0) + Local0 *= 10
// Adjust by offset to get Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46171
to look at the new patch set (#2).
Change subject: mb/google/butterfly: Convert to ASL 2.0 syntax ......................................................................
mb/google/butterfly: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are same.
Change-Id: I85edf649a5170a1658fb135b797c1c6e1d2a9d70 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/butterfly/acpi/mainboard.asl M src/mainboard/google/butterfly/acpi/platform.asl M src/mainboard/google/butterfly/acpi/thermal.asl 3 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46171/2
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46171 )
Change subject: mb/google/butterfly: Convert to ASL 2.0 syntax ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46171 )
Change subject: mb/google/butterfly: Convert to ASL 2.0 syntax ......................................................................
mb/google/butterfly: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are same.
Change-Id: I85edf649a5170a1658fb135b797c1c6e1d2a9d70 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46171 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/google/butterfly/acpi/mainboard.asl M src/mainboard/google/butterfly/acpi/platform.asl M src/mainboard/google/butterfly/acpi/thermal.asl 3 files changed, 12 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/google/butterfly/acpi/mainboard.asl b/src/mainboard/google/butterfly/acpi/mainboard.asl index 02ef905..3552e29 100644 --- a/src/mainboard/google/butterfly/acpi/mainboard.asl +++ b/src/mainboard/google/butterfly/acpi/mainboard.asl @@ -8,7 +8,7 @@ Name (_HID, EisaId("PNP0C0D")) Method (_LID, 0) { - Store (_SB.PCI0.LPCB.EC0.LIDF, \LIDS) + \LIDS = _SB.PCI0.LPCB.EC0.LIDF Return (\LIDS) } } diff --git a/src/mainboard/google/butterfly/acpi/platform.asl b/src/mainboard/google/butterfly/acpi/platform.asl index f59e485..7c8a815 100644 --- a/src/mainboard/google/butterfly/acpi/platform.asl +++ b/src/mainboard/google/butterfly/acpi/platform.asl @@ -15,16 +15,16 @@ { /* Update in case state changed while asleep */ /* Update AC status */ - Store (_SB.PCI0.LPCB.EC0.ADPT, Local0) - if (LNotEqual (Local0, \PWRS)) { - Store (Local0, \PWRS) + Local0 = _SB.PCI0.LPCB.EC0.ADPT + if (Local0 != \PWRS) { + \PWRS = Local0 Notify (_SB.PCI0.LPCB.EC0.AC, 0x80) }
/* Update LID status */ - Store (_SB.PCI0.LPCB.EC0.LIDF, Local0) - if (LNotEqual (Local0, \LIDS)) { - Store (Local0, \LIDS) + Local0 = _SB.PCI0.LPCB.EC0.LIDF + if (Local0 != \LIDS) { + \LIDS = Local0 Notify (_SB.LID0, 0x80) }
diff --git a/src/mainboard/google/butterfly/acpi/thermal.asl b/src/mainboard/google/butterfly/acpi/thermal.asl index 4c6f6d9..ed381cd 100644 --- a/src/mainboard/google/butterfly/acpi/thermal.asl +++ b/src/mainboard/google/butterfly/acpi/thermal.asl @@ -21,10 +21,10 @@ // Convert from Degrees C to 1/10 Kelvin for ACPI Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10
// Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) } @@ -50,13 +50,13 @@ Method (_TMP, 0, Serialized) { // Get CPU Temperature from EC - Store (_SB.PCI0.LPCB.EC0.CTMP, Local0) + Local0 = _SB.PCI0.LPCB.EC0.CTMP
// Convert to 1/10 Kelvin - Multiply (Local0, 10, Local0) + Local0 *= 10
// Adjust by offset to get Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) }
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)