Attention is currently required from: Tim Wawrzynczak, Paul Menzel.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56877 )
Change subject: drivers/generic/alc1015: Add HID to support alc1019
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/generic/alc1015/chip.h:
https://review.coreboot.org/c/coreboot/+/56877/comment/628c560f_4646c23f
PS2, Line 6: const char *hid; /* ACPI _HID */
WDYT about an enum, e.g.: […]
this can work as well. but if just use the hid... we don't have to maintain this driver if new IC coming. Since reltek don't want to maintain this...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56877
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5
Gerrit-Change-Number: 56877
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 10 Aug 2021 03:44:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment