Attention is currently required from: Jakub Czapiga, Julius Werner, Maximilian Brune, Nico Huber, Philipp Hug, ron minnich.
Hello Jakub Czapiga, Julius Werner, Maximilian Brune, Philipp Hug, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79907?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed: Code-Review+1 by Julius Werner, Verified+1 by build bot (Jenkins)
Change subject: region: Hide struct region members ......................................................................
region: Hide struct region members
We cannot make `struct region` opaque for several reasons (size needs to be known for local objects, a lot of inline API functions, ...). However, we still want to encourage using the high-level region API instead of directly accessing and manipulating the struct members. This patch tries to achieve this by renaming the struct members. Only if REGION_INTERNAL_STRUCTURES is defined before including <region.h>, the usual member names are used.
Change-Id: I713be9cf0bab4c2e21113b55e7229ab50f06c6cf Signed-off-by: Nico Huber nico.h@gmx.de --- M src/commonlib/include/commonlib/region.h M src/commonlib/region.c M tests/commonlib/Makefile.mk M tests/commonlib/region-test.c M tests/lib/cbfs-lookup-test.c M tests/lib/fmap-test.c 6 files changed, 35 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/79907/9