Change in coreboot[master]: mb/google/cherry: support max98390 audio amp - coreboot-gerrit

25 Mar 2022


      Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Trevor Wu.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63083 )
Change subject: mb/google/cherry: support max98390 audio amp
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/cherry/chromeos.c:
https://review.coreboot.org/c/coreboot/+/63083/comment/6adfef04_abb4d46e 
PS4, Line 26:
...
I wonder can we do that by Kconfig 'choice' group, so all the CHERRY_USE_* will be inside a choice g […]
Good idea.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63083
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b6bc5a5520292dd502b0389217f5062479b4490
Gerrit-Change-Number: 63083
Gerrit-PatchSet: 6
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Trevor Wu trevor.wu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Trevor Wu trevor.wu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 25 Mar 2022 08:52:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Comment-In-Reply-To: Rex-BC Chen rex-bc.chen@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment