Attention is currently required from: Joey Peng, Henry Sun, Marco Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 )
Change subject: mb/google/octopus/var/phaser:Change IRQ trigger method to level due to vendor spec ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56380/comment/a28c358a_2733759e PS1, Line 7: src/mainboard/google/octopus/variants/phaser Please look at `git log --oneline` how prefixes are composed.
https://review.coreboot.org/c/coreboot/+/56380/comment/baedb37a_9b333722 PS1, Line 7: src/mainboard/google/octopus/variants/phaser:Change Please add a space after the colon.
https://review.coreboot.org/c/coreboot/+/56380/comment/b31c6042_f2465c5a PS1, Line 9: The change from Synaptics S7817 to Elan 3915N What do you mean? The ELAN touchpad is already configured in the devicetree, isn’t it?
https://review.coreboot.org/c/coreboot/+/56380/comment/fa7b14b4_de10b42a PS1, Line 9: The change from Synaptics S7817 to Elan 3915N and pin distribution of touch IC is the same. : : According to vendor spec definition IRQ trigger method needs to change to level. Please wrap lines after 75 characters.