Attention is currently required from: David Wu, Morris Hsu, Ren Kuo, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change by Morris Hsu. ( https://review.coreboot.org/c/coreboot/+/83874?usp=email )
Change subject: mb/google/brox/jubilant: Disable devcies and GPIOs by fw_config
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83874/comment/4b8c3b3c_f9db6730?usp... :
PS7, Line 3: STORAGE_UNKNOWN
It should be STORAGE_UNPROVISIONED and its value/mask should be 3.
https://review.coreboot.org/c/coreboot/+/83874/comment/a585f01b_19acc8df?usp... :
PS7, Line 297: STORAGE_UNKNOWN
I think it should be STORAGE_UNPROVISIONED. An unprovisioned FW_CONFIG should be 0xffffffff. That should support first boot in factory. An unknown STORAGE means some part of FW_CONFIG is provisioned which is not correct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83874?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d9f4edea454e0861f91261bf13fa80572d0a181
Gerrit-Change-Number: 83874
Gerrit-PatchSet: 7
Gerrit-Owner: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 12 Aug 2024 16:50:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No