Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41607 )
Change subject: drivers/intel/mipi_camera: camera SSDT generation ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... PS11, Line 272: 0
Is this always supposed to be 0?
It's zero for all the existing systems in coreboot, though the docs in the Linux kernel have examples of devices where it's set to non-zero (e.g., ov7251 and ov5645). The 'head' of the Linux kernel seems to default to zero, so I did wonder if it's worthwhile to specify but I didn't read the code in detail nor check older kernel versions.
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... PS11, Line 303: /* endpoint? */
?
acpi_graph_get_remote_endpoint() seems to confirm my guess, where a comment says that port and endpoint indices are provided as arguments.
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... PS11, Line 315: 180
always 180?
So far only nautilus's cam0.asl specifies a "rotation" and it uses 180.
-
Matt Delco (Code Review)