Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42423 )
Change subject: ACPI: Add framework for GNVS initialisation
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42423/5/src/acpi/chromeos-gnvs.c
File src/acpi/chromeos-gnvs.c:
https://review.coreboot.org/c/coreboot/+/42423/5/src/acpi/chromeos-gnvs.c@14
PS5, Line 14: gnvs_chromeos->vbt2 = ACTIVE_ECFW_RO;
Why not just put this inside chromeos_init_chromeos_acpi()?
https://review.coreboot.org/c/coreboot/+/42423/5/src/acpi/gnvs.c
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/42423/5/src/acpi/gnvs.c@55
PS5, Line 55: gnvs_assign_chromeos();
Does it matter if we call this twice until CB:42493 lands? I have it here in case there was a need t […]
Briefly looking it's just assigning to fields. I don't see any side effects.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccad533c3824d70f6cbae52cc8dd79f142ece944
Gerrit-Change-Number: 42423
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jun 2020 18:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment