Attention is currently required from: Hung-Te Lin, Felix Singer, Patrick Rudolph.
Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62278 )
Change subject: i2c: Add configurable I2C transfer timeout
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62278/comment/22a94f71_9687d58f
PS7, Line 7: Configurable
Add configurable ...
Done
Patchset:
PS8:
I have updated the commit message based on comments, and to state the rationale for changing the timeouts across the board.
File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/c/coreboot/+/62278/comment/81327af7_a4e10d25
PS7, Line 242: CONFIG_I2C_TRANSFER_TIMEOUT_US
I would suggest we change all affected timeouts to the new default unless someone has an explicit re […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62278
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6423122f32aad1dbcee0bfe240cdaa8cb512791f
Gerrit-Change-Number: 62278
Gerrit-PatchSet: 8
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Qii Wang
qii.wang@mediatek.corp-partner.google.com
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 23:59:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment