Attention is currently required from: Won Chung, Benson Leung, Prashant Malani. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61388 )
Change subject: mb/google/brya: Add custom PLD fields to device tree ......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61388/comment/629b35d4_f65745e8 PS6, Line 658: 1" `PLD_HORIZONTAL_POSITION_CENTER`
https://review.coreboot.org/c/coreboot/+/61388/comment/3dd68e2d_1738e694 PS6, Line 655: register "use_custom_pld" = "true" : register "custom_pld.visible" = "true" : register "custom_pld.panel" = "PLD_PANEL_LEFT" : register "custom_pld.horizontal_position" = "1" : register "custom_pld.shape" = "PLD_SHAPE_OVAL" : register "custom_pld.group" = "ACPI_PLD_GROUP(1, 1)" We can clean up some of the wordiness like so:
``` register "use_custom_pld" = "true" register "custom_pld" = "{ .visible = true, .panel = PLD_PANEL_LEFT, .horizontal_position = PLD_HORIZONTAL_POSITION_CENTER, .shape = PLD_SHAPE_OVAL, .group = ACPI_PLD_GROUP(1, 1)}" ```
it will make all of them a little less cluttered 👍