Attention is currently required from: Felix Singer, Julius Werner, Lean Sheng Tan, Maximilian Brune, Nico Huber.
Angel Pons has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83615?usp=email )
Change subject: util/cbfstool/cbfs-payload-linux: Do not compress bzImage ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83615/comment/c7d63b39_7dae75b1?usp... : PS3, Line 12: erros typo: errors
File util/cbfstool/cbfs-payload-linux.c:
https://review.coreboot.org/c/coreboot/+/83615/comment/aefd8b00_e73f4296?usp... : PS3, Line 159: comp_func_ptr compress_func = compression_function(algo); Looks like `algo` only needs to be different when `type == PAYLOAD_SEGMENT_CODE`. Would it make sense to keep `enum cbfs_compression algo` in `struct bzpayload` to avoid having to pass the algo as parameter?
``` /* There is no point in compressing the bzImage (it is already compressed) */ const cbfs_compression algo = type == PAYLOAD_SEGMENT_CODE ? CBFS_COMPRESS_NONE : bzp->algo; comp_func_ptr compress_func = compression_function(algo); compress_func(buffer_get(b), buffer_size(b), buffer_get(&out), &len); ```
https://review.coreboot.org/c/coreboot/+/83615/comment/be068c8b_41740b56?usp... : PS3, Line 294: // There is no point in compressing the bzImage (it is already compressed) nit: consistent comment style