Attention is currently required from: Bora Guvendik, Shaunak Saha, Anil Kumar K, Cliff Huang, Furquan Shaikh, Wonkyu Kim, Bernardo Perez Priego, Srinidhi N Kaushik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50897 )
Change subject: soc/intel/tigerlake: Add CNVi Bluetooth flag at devicetree entry
......................................................................
Patch Set 11:
(4 comments)
Patchset:
PS9:
@Angel, I am not quite understand . […]
Sounds good.
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/50897/comment/467fa981_a4aa2833
PS6, Line 320: uint8_t
In FSP, UINT8 is used. […]
Done
https://review.coreboot.org/c/coreboot/+/50897/comment/5f677e17_631bb290
PS6, Line 320: CnviBtCore
Same naming convention is used, like other CNVi variables: CnviMode, CnviBtAudioOffload.
Not a big deal
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/50897/comment/5d93b2cb_efc64e77
PS6, Line 357: params->CnviBtCore = config->CnviBtCore;
@Angel, @Shaunak, If the last change is fine, please help with +1 and I will rebase the other 3 code […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50897
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71c512fe884060e23ee26e7334c575c4c517b78d
Gerrit-Change-Number: 50897
Gerrit-PatchSet: 11
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: AndreX Andraos
andrex.andraos@intel.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 04 Mar 2021 21:24:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha
shaunak.saha@intel.com
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment