Change in coreboot[master]: mb/google/volteer: Convert to ASL 2.0 syntax

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46222 )

Change subject: mb/google/volteer: Convert to ASL 2.0 syntax
......................................................................

mb/google/volteer: Convert to ASL 2.0 syntax

Change-Id: I84bd93970e363bed4c4da616b5c16ac7e2332861
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46222/1

diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
index 51034c3..91f4e8f 100644
--- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
+++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
@@ -178,12 +178,12 @@
 #endif
    			Sleep(1) /* t2 */

-				Store(1,STA)
+				STA = 1
    		}
    	}
    	Method (_OFF, 0, Serialized)  /* Rear camera _OFF: Power Off */
    	{
-			If ((STA == One))
+			If (STA == 1)
    		{
    			/* Disable IMG_CLK */
    			Sleep(1) /* t0+t1 */
@@ -202,7 +202,7 @@
    			/* Pull SNRPWR_EN low */
    			CTXS(GPP_H14)

-				Store(0,STA)
+				STA = 0
    		}
    	}
    	Method (_STA, 0, NotSerialized)  /* _STA: Status */
@@ -479,12 +479,12 @@
    			STXS(GPP_D4)
    			Sleep(1) /* t2 */

-				Store(1,STA)
+				STA = 1
    		}
    	}
    	Method (_OFF, 0, Serialized)  /* Front camera_OFF_: Power Off */
    	{
-			If ((STA == One))
+			If (STA == 1)
    		{
    			/* Disable IMG_CLK */
    			Sleep(1) /* t0+t1 */
@@ -499,7 +499,7 @@
    			/* Pull SNRPWR_EN low */
    			CTXS(GPP_D18)

-				Store(0,STA)
+				STA = 0
    		}
    	}
    	Method (_STA, 0, NotSerialized)  /* _STA: Status */

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: HAOUAS Elyes.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46222 )

Change subject: mb/google/volteer: Convert to ASL 2.0 syntax
......................................................................

Patch Set 1: Code-Review+2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46222 )

Change subject: mb/google/volteer: Convert to ASL 2.0 syntax
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: 
Thx
looks like this is already done on commit 8661fe220d92cedbb5eb7956d74b764670d354f3

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: HAOUAS Elyes.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46222 )

Change subject: mb/google/volteer: Convert to ASL 2.0 syntax
......................................................................

Patch Set 1: -Code-Review

(1 comment)

Patchset:

PS1:
> Thx […]

Oh I forgot we converted it already 😊

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46222 )

Change subject: mb/google/volteer: Convert to ASL 2.0 syntax
......................................................................

Abandoned

already done