Change in ...coreboot[master]: drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )

Change subject: drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................

Patch Set 55:
> Yes @Idwer, can you please help me to know your requirements so that i can intercept the same in this CL or future CL as it required.

I can't speak for Idwer, but he seemed to have similar thoughts.
Here are mine:

1. Stop replacing open-source coreboot functionality with blobs.
The justification for this change seems to be that the SkipMpInit
option will vanish. To me, it seems like a huge offense to coreboot.
There are hundreds of copyright holders on the open-source side
and a single one on the blob side, yet the blob side enforces their
will. This change shows me that even after the past 5 years of
FSP integration and promises, we are still running coreboot down
further and further. Maybe this is a strategy? only stop when
coreboot development has become that expensive that nobody
wants it anymore? At least for a smaller company, the one I work
for, the costs for coreboot development exploded since the
introduction of FSP.

2. In case 1. happens anyway, find a less offensive way to
integrate the blob. Calling GPL code from the blob makes it
harder for me to see them as separate works as requested by
the GPL (not to mention the requested separate distribution).
We have learned during the discussion of this change that there
are alternatives that could avoid calling GPL code from the blob.
In that case, coreboot and FSP would run redundant code and I
assume things would be slowed down. So I see this change as a
mitigation for the ugly design of FSP, spitting into the faces
of contributors that saw their code protected by the GPL.