Change in coreboot[master]: UPSTREAM: mb/google/volteer/var/voxel: Update DPTF parameters
Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47858 )
Change subject: UPSTREAM: mb/google/volteer/var/voxel: Update DPTF parameters ......................................................................
UPSTREAM: mb/google/volteer/var/voxel: Update DPTF parameters
update the DPTF parameters received from the thermal team.
BUG=b:167523658 TEST=emerge-volteer coreboot
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: Iafc3fb389ade5cfec79a816a28880262bdce7c74 --- M src/mainboard/google/volteer/variants/voxel/overridetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47858/1
diff --git a/src/mainboard/google/volteer/variants/voxel/overridetree.cb b/src/mainboard/google/volteer/variants/voxel/overridetree.cb index dd29553..9c4aa47 100644 --- a/src/mainboard/google/volteer/variants/voxel/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voxel/overridetree.cb @@ -23,22 +23,22 @@ ## Active Policy register "policies.active" = "{ [0] = {.target = DPTF_CPU, - .thresholds = {TEMP_PCT(94, 100),}}, + .thresholds = {TEMP_PCT(98, 100),}}, [1] = {.target = DPTF_TEMP_SENSOR_2, .thresholds = {TEMP_PCT(64, 100), TEMP_PCT(60, 90), TEMP_PCT(56, 80), TEMP_PCT(52, 70), - TEMP_PCT(48, 60), - TEMP_PCT(44, 50), - TEMP_PCT(40, 40),}}}" + TEMP_PCT(47, 60), + TEMP_PCT(42, 50), + TEMP_PCT(35, 40),}}}"
## Passive Policy register "policies.passive" = "{ [0] = DPTF_PASSIVE(CPU, CPU, 95, 5000), [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), - [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 54, 6000), + [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 52, 6000), [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}"
## Critical Policy @@ -58,7 +58,7 @@ .time_window_min = 28 * MSECS_PER_SEC, .time_window_max = 32 * MSECS_PER_SEC, .granularity = 200,}, - .pl2 = {.min_power = 15000, + .pl2 = {.min_power = 51000, .max_power = 51000, .time_window_min = 28 * MSECS_PER_SEC, .time_window_max = 32 * MSECS_PER_SEC,
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47858 )
Change subject: UPSTREAM: mb/google/volteer/var/voxel: Update DPTF parameters ......................................................................
Patch Set 1: Code-Review+1
David Wu has uploaded a new patch set (#2) to the change originally created by Sheng-Liang Pan. ( https://review.coreboot.org/c/coreboot/+/47858 )
Change subject: mb/google/volteer/var/voxel: Update DPTF parameters ......................................................................
mb/google/volteer/var/voxel: Update DPTF parameters
update the DPTF parameters received from the thermal team.
BUG=b:167523658 TEST=emerge-volteer coreboot
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: Iafc3fb389ade5cfec79a816a28880262bdce7c74 --- M src/mainboard/google/volteer/variants/voxel/overridetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/47858/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47858 )
Change subject: mb/google/volteer/var/voxel: Update DPTF parameters ......................................................................
Patch Set 2: Code-Review+2
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47858 )
Change subject: mb/google/volteer/var/voxel: Update DPTF parameters ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47858 )
Change subject: mb/google/volteer/var/voxel: Update DPTF parameters ......................................................................
mb/google/volteer/var/voxel: Update DPTF parameters
update the DPTF parameters received from the thermal team.
BUG=b:167523658 TEST=emerge-volteer coreboot
Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: Iafc3fb389ade5cfec79a816a28880262bdce7c74 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47858 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/voxel/overridetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Sumeet R Pawnikar: Looks good to me, approved Sheng-Liang Pan: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/voxel/overridetree.cb b/src/mainboard/google/volteer/variants/voxel/overridetree.cb index dd29553..9c4aa47 100644 --- a/src/mainboard/google/volteer/variants/voxel/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voxel/overridetree.cb @@ -23,22 +23,22 @@ ## Active Policy register "policies.active" = "{ [0] = {.target = DPTF_CPU, - .thresholds = {TEMP_PCT(94, 100),}}, + .thresholds = {TEMP_PCT(98, 100),}}, [1] = {.target = DPTF_TEMP_SENSOR_2, .thresholds = {TEMP_PCT(64, 100), TEMP_PCT(60, 90), TEMP_PCT(56, 80), TEMP_PCT(52, 70), - TEMP_PCT(48, 60), - TEMP_PCT(44, 50), - TEMP_PCT(40, 40),}}}" + TEMP_PCT(47, 60), + TEMP_PCT(42, 50), + TEMP_PCT(35, 40),}}}"
## Passive Policy register "policies.passive" = "{ [0] = DPTF_PASSIVE(CPU, CPU, 95, 5000), [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), - [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 54, 6000), + [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 52, 6000), [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}"
## Critical Policy @@ -58,7 +58,7 @@ .time_window_min = 28 * MSECS_PER_SEC, .time_window_max = 32 * MSECS_PER_SEC, .granularity = 200,}, - .pl2 = {.min_power = 15000, + .pl2 = {.min_power = 51000, .max_power = 51000, .time_window_min = 28 * MSECS_PER_SEC, .time_window_max = 32 * MSECS_PER_SEC,
-
David Wu (Code Review) -
Sheng-Liang Pan (Code Review)
-
Sumeet R Pawnikar (Code Review)
-
Tim Wawrzynczak (Code Review)