Change in coreboot[master]: src: Drop unused <cpu/x86/smm.h> include

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42392 )

Change subject: src: Drop unused <cpu/x86/smm.h> include
......................................................................

src: Drop unused <cpu/x86/smm.h> include

Change-Id: Id96ddad974a1460a6e6580cee1e45c863761af06
Signed-off-by: Elyes HAOUAS 
---
M src/cpu/intel/smm/cpu_svrstr.c
M src/soc/intel/common/block/pmc/pmc.c
M src/soc/intel/skylake/romstage/romstage.c
3 files changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/42392/1

diff --git a/src/cpu/intel/smm/cpu_svrstr.c b/src/cpu/intel/smm/cpu_svrstr.c
index d7e161f..1e63dd2 100644
--- a/src/cpu/intel/smm/cpu_svrstr.c
+++ b/src/cpu/intel/smm/cpu_svrstr.c
@@ -4,7 +4,6 @@
 #include <console/console.h>
 #include <cpu/x86/msr.h>
 #include <cpu/x86/mp.h>
-#include <cpu/x86/smm.h>
 #include <cpu/intel/smm_reloc.h>

#define SMBASE_MSR 0xc20
diff --git a/src/soc/intel/common/block/pmc/pmc.c b/src/soc/intel/common/block/pmc/pmc.c
index 7979bfd..67aacd9 100644
--- a/src/soc/intel/common/block/pmc/pmc.c
+++ b/src/soc/intel/common/block/pmc/pmc.c
@@ -4,7 +4,6 @@
 #include <arch/io.h>
 #include <device/pci_ops.h>
 #include <console/console.h>
-#include <cpu/x86/smm.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
 #include <intelblocks/pmc.h>
diff --git a/src/soc/intel/skylake/romstage/romstage.c b/src/soc/intel/skylake/romstage/romstage.c
index 99f444a..9ae854d 100644
--- a/src/soc/intel/skylake/romstage/romstage.c
+++ b/src/soc/intel/skylake/romstage/romstage.c
@@ -4,7 +4,6 @@
 #include <arch/symbols.h>
 #include <assert.h>
 #include <cpu/x86/msr.h>
-#include <cpu/x86/smm.h>
 #include <cbmem.h>
 #include <console/console.h>
 #include <device/pci_def.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42392 )

Change subject: src: Drop unused <cpu/x86/smm.h> include
......................................................................

Patch Set 1:

Please do not push on this branch. There is high chance of accidentally rebasing everything and triggering the whole train to be built again.

Change in coreboot[master]: soc/intel/skylake/romstage: Remove unused include <cpu/x86/smm.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Kyösti Mälkki, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42392

to look at the new patch set (#2).

Change subject: soc/intel/skylake/romstage: Remove unused include <cpu/x86/smm.h>
......................................................................

soc/intel/skylake/romstage: Remove unused include <cpu/x86/smm.h>

Change-Id: Id96ddad974a1460a6e6580cee1e45c863761af06
Signed-off-by: Elyes HAOUAS 
---
M src/soc/intel/skylake/romstage/romstage.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/42392/2

Change in coreboot[master]: soc/intel/skylake/romstage: Remove unused include <cpu/x86/smm.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Kyösti Mälkki, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42392

to look at the new patch set (#3).

Change subject: soc/intel/skylake/romstage: Remove unused include <cpu/x86/smm.h>
......................................................................

soc/intel/skylake/romstage: Remove unused include <cpu/x86/smm.h>

Found using:
diff <(git grep -l '#include <cpu/x86/smm.h>' -- src/) <(git grep -l 'SMM_DEFAULT_BASE|SMM_DEFAULT_SIZE|SMM_BASE|SMM_ENTRY_OFFSET|SMM_SAVE_STATE_BEGIN|APM_CNT|APM_STS|apm_control|set_smm_gnvs_ptr|set_acpi_mode_on_exit|io_trap_handler|southbridge_io_trap_handler|mainboard_io_trap_handler|southbridge_smi_set_eos|smm_southbridge_clear_state|global_smi_enable|global_smi_enable_no_pwrbtn|cpu_smi_handler|northbridge_smi_handler|southbridge_smi_handler|mainboard_smi_gpi|mainboard_smi_apmc|mainboard_smi_sleep|smramc_dev|smramc_reg|run_smm_relocate|smm_is_really_enabled|is_smm_enabled|smram_open|smram_close|smram_lock|smm_open|smm_close|smm_lock|_binary_smm_start|_binary_smm_end|smm_runtime|smm_module_params|smm_handler_start|smm_get_save_state|smm_handler_t|smm_loader_params|smm_setup_relocation_handler|smm_load_module|backup_default_smm_area|restore_default_smm_area|smm_region|SMM_SUBREGION_HANDLER|SMM_SUBREGION_CACHE|SMM_SUBREGION_CHIPSET|SMM_SUBREGION_NUM|smm_subregion|smm_list_regions' -- src/)|grep '>'

Change-Id: Id96ddad974a1460a6e6580cee1e45c863761af06
Signed-off-by: Elyes HAOUAS 
---
M src/soc/intel/skylake/romstage/romstage.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/42392/3

Change in coreboot[master]: soc/intel/skylake/romstage: Remove unused include <cpu/x86/smm.h>

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42392 )

Change subject: soc/intel/skylake/romstage: Remove unused include <cpu/x86/smm.h>
......................................................................

Abandoned

see 41969

Change in coreboot[master]: soc/intel/skylake/romstage: Remove unused include <cpu/x86/smm.h>

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/42392 )

Change subject: soc/intel/skylake/romstage: Remove unused include <cpu/x86/smm.h>
......................................................................

Restored

Change in coreboot[master]: src: Remove unused include <cpu/x86/smm.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Kyösti Mälkki, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42392

to look at the new patch set (#4).

Change subject: src: Remove unused include <cpu/x86/smm.h>
......................................................................

src: Remove unused include <cpu/x86/smm.h>

Found using:
diff <(git grep -l '#include <cpu/x86/smm.h>' -- src/) <(git grep -l 'SMM_DEFAULT_BASE|SMM_DEFAULT_SIZE|SMM_BASE|SMM_ENTRY_OFFSET|SMM_SAVE_STATE_BEGIN|APM_CNT|APM_STS|apm_control|set_smm_gnvs_ptr|set_acpi_mode_on_exit|io_trap_handler|southbridge_io_trap_handler|mainboard_io_trap_handler|southbridge_smi_set_eos|smm_southbridge_clear_state|global_smi_enable|global_smi_enable_no_pwrbtn|cpu_smi_handler|northbridge_smi_handler|southbridge_smi_handler|mainboard_smi_gpi|mainboard_smi_apmc|mainboard_smi_sleep|smramc_dev|smramc_reg|run_smm_relocate|smm_is_really_enabled|is_smm_enabled|smram_open|smram_close|smram_lock|smm_open|smm_close|smm_lock|_binary_smm_start|_binary_smm_end|smm_runtime|smm_module_params|smm_handler_start|smm_get_save_state|smm_handler_t|smm_loader_params|smm_setup_relocation_handler|smm_load_module|backup_default_smm_area|restore_default_smm_area|smm_region|SMM_SUBREGION_HANDLER|SMM_SUBREGION_CACHE|SMM_SUBREGION_CHIPSET|SMM_SUBREGION_NUM|smm_subregion|smm_list_regions' -- src/)|grep '<'

Change-Id: Id96ddad974a1460a6e6580cee1e45c863761af06
Signed-off-by: Elyes HAOUAS 
---
M src/drivers/smmstore/smi.c
M src/soc/intel/skylake/romstage/romstage.c
2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/42392/4

Change in coreboot[master]: src: Remove unused include <cpu/x86/smm.h>

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42392 )

Change subject: src: Remove unused include <cpu/x86/smm.h>
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: src: Remove unused include <cpu/x86/smm.h>

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42392 )

Change subject: src: Remove unused include <cpu/x86/smm.h>
......................................................................

src: Remove unused include <cpu/x86/smm.h>

Found using:
diff <(git grep -l '#include <cpu/x86/smm.h>' -- src/) <(git grep -l 'SMM_DEFAULT_BASE|SMM_DEFAULT_SIZE|SMM_BASE|SMM_ENTRY_OFFSET|SMM_SAVE_STATE_BEGIN|APM_CNT|APM_STS|apm_control|set_smm_gnvs_ptr|set_acpi_mode_on_exit|io_trap_handler|southbridge_io_trap_handler|mainboard_io_trap_handler|southbridge_smi_set_eos|smm_southbridge_clear_state|global_smi_enable|global_smi_enable_no_pwrbtn|cpu_smi_handler|northbridge_smi_handler|southbridge_smi_handler|mainboard_smi_gpi|mainboard_smi_apmc|mainboard_smi_sleep|smramc_dev|smramc_reg|run_smm_relocate|smm_is_really_enabled|is_smm_enabled|smram_open|smram_close|smram_lock|smm_open|smm_close|smm_lock|_binary_smm_start|_binary_smm_end|smm_runtime|smm_module_params|smm_handler_start|smm_get_save_state|smm_handler_t|smm_loader_params|smm_setup_relocation_handler|smm_load_module|backup_default_smm_area|restore_default_smm_area|smm_region|SMM_SUBREGION_HANDLER|SMM_SUBREGION_CACHE|SMM_SUBREGION_CHIPSET|SMM_SUBREGION_NUM|smm_subregion|smm_list_regions' -- src/)|grep '<'

Change-Id: Id96ddad974a1460a6e6580cee1e45c863761af06
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42392
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/drivers/smmstore/smi.c
M src/soc/intel/skylake/romstage/romstage.c
2 files changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/drivers/smmstore/smi.c b/src/drivers/smmstore/smi.c
index b21423e..877ed20 100644
--- a/src/drivers/smmstore/smi.c
+++ b/src/drivers/smmstore/smi.c
@@ -2,7 +2,6 @@

#include <console/console.h>
 #include <commonlib/region.h>
-#include <cpu/x86/smm.h>
 #include <smmstore.h>
 #include <stddef.h>
 #include <stdint.h>
diff --git a/src/soc/intel/skylake/romstage/romstage.c b/src/soc/intel/skylake/romstage/romstage.c
index 99f444a..9ae854d 100644
--- a/src/soc/intel/skylake/romstage/romstage.c
+++ b/src/soc/intel/skylake/romstage/romstage.c
@@ -4,7 +4,6 @@
 #include <arch/symbols.h>
 #include <assert.h>
 #include <cpu/x86/msr.h>
-#include <cpu/x86/smm.h>
 #include <cbmem.h>
 #include <console/console.h>
 #include <device/pci_def.h>