Attention is currently required from: Martin L Roth, Paul Menzel.
Tim Crawford has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82788?usp=email )
Change subject: mb/system76/mtl: Add Lemur Pro 13 ......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/system76/mtl/variants/lemp13/ramstage.c:
https://review.coreboot.org/c/coreboot/+/82788/comment/06b321c7_1784efdf?usp... : PS3, Line 14: params->EnableTcssCovTypeA[1] = 0x81; : params->EnableTcssCovTypeA[3] = 0x85;
Waiting on either Intel to release a Client FSP or Google to do whatever they do to update the heade […]
I give up. I just commented it out so downstream we will only have to uncomment it.
File src/mainboard/system76/mtl/variants/lemp13/tas5825m.c:
PS2:
- Driver was added in CB:43614 […]
Done
https://review.coreboot.org/c/coreboot/+/82788/comment/e5267b54_1b8ad94d?usp... : PS2, Line 44: { : const uint8_t values[] = { : 0x00, 0xFE, 0x00, 0x40, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x50, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0xFC, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x00, : 0x00, 0x82, 0x00, 0x93, 0x00, 0xFC, 0x00, 0x00, : 0x8F, 0x00, 0xFF, 0xEF, 0x84, 0x49, 0x03, 0x27, : 0x84, 0x02, 0x04, 0x06, 0x02, 0x60, 0x00, 0x01, : 0x00 : }; : res = tas5825m_write_block_at(dev, 0x08, values, ARRAY_SIZE(values)); : if (res < 0) : return res; : }
When the driver was originally written these were all big blocks of 1 byte writes each. […]
Done
-
Tim Crawford (Code Review)