[L] Change in coreboot[main]: superio/ite/common: Add common driver for GPIO and LED configuration

[Nico Huber (Code Review)]

Attention is currently required from: Michał Żygowski.

Nico Huber has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83355?usp=email )

Change subject: superio/ite/common: Add common driver for GPIO and LED configuration
......................................................................

Patch Set 3: Code-Review+2

(6 comments)

File src/mainboard/samsung/stumpy/smihandler.c:

https://review.coreboot.org/c/coreboot/+/83355/comment/4e8c0c9c_abea00f6?usp... :
PS1, Line 25: 		ite_reg_write(GPIO_DEV, IT8772F_GPIO_REG_SELECT(3), 0x20);
> Done in CB:83469

Acknowledged

https://review.coreboot.org/c/coreboot/+/83355/comment/81eb7abe_19c9be17?usp... :
PS1, Line 39: 		ite_reg_write(GPIO_DEV, IT8772F_GPIO_REG_SELECT(3), 0x20);
> Done in CB:83469

Acknowledged

https://review.coreboot.org/c/coreboot/+/83355/comment/fb1b533d_df71e40f?usp... :
PS1, Line 49: 			ITE_LED_FREQ_1HZ);
> Done in CB:83469

Acknowledged

File src/superio/ite/common/gpio.c:

https://review.coreboot.org/c/coreboot/+/83355/comment/2553f7da_e1159219?usp... :
PS1, Line 130: 	 */
> Added the function which checks for the register presence like for the other 2 registers. […]

Acknowledged

File src/superio/ite/it8772f/it8772f.h:

https://review.coreboot.org/c/coreboot/+/83355/comment/3767ae12_3d2eccd4?usp... :
PS1, Line 16: 
            : /* GPIO Polarity Select: 1: Inverting, 0: Non-inverting */
            : #define IT8772F_GPIO_REG_POLARITY(x) (0xb0 + (x))
            : 
            : /* GPIO Internal Pull-up: 1: Enable, 0: Disable */
            : #define IT8772F_GPIO_REG_PULLUP(x)   (0xb8 + (x))
            : 
            : /* GPIO Function Select: 1: Simple I/O, 0: Alternate function */
            : #define IT8772F_GPIO_REG_ENABLE(x)   (0xc0 + (x))
            : 
            : /* GPIO Mode: 0: input mode, 1: output mode */
            : #define IT8772F_GPIO_REG_OUTPUT(x)   (0xc8 + (x))
            :
> Removed in CB:83469 […]

Acknowledged

File src/superio/ite/it8786e/Kconfig:

https://review.coreboot.org/c/coreboot/+/83355/comment/c7eb6943_9459f3f0?usp... :
PS1, Line 16: 	default 10
> In the "IT8786E-I Preliminary SPecification v0.4.1 for D version" […]

Ok, I only found a v0.2 and was going by the pins. But it's certainly possible
that there are packages with more GPIO.