Change in coreboot[master]: mb/prodrive/hermes: Configure pink rear vref based on eeprom - coreboot-gerrit

3 Nov 2021


      Attention is currently required from: Justin van Son, Christian Walter, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58879 )
Change subject: mb/prodrive/hermes: Configure pink rear vref based on eeprom
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/58879/comment/65317e94_cc8cb871 
PS1, Line 82: 	const u32 internal_config = get_internal_audio_cfg(board_cfg->internal_audio_connection);
...
actually, you can name it front_panel. […]
Sounds good. I made CB:58904 to rename this.
@Arthur, could you rebase this change atop CB:58904 please?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58879
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa11ba9c74f643e94046d4983fbce65dbedd1025
Gerrit-Change-Number: 58879
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Justin van Son justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Justin van Son justin.van.son@prodrive-technologies.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 03 Nov 2021 11:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin van Son justin.van.son@prodrive-technologies.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment