Change in coreboot[master]: mb/google/brya/variants/primus: add fw_config_probe for ALC5682I-VS - coreboot-gerrit

17 Nov 2021


      Attention is currently required from: Malik Hsu.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59367 )
Change subject: mb/google/brya/variants/primus: add fw_config_probe for ALC5682I-VS
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
https://review.coreboot.org/c/coreboot/+/59367/comment/a3003fe7_cffa0525 
PS3, Line 25: 	if (fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_VS_I2S))) {
nit: blank line before this one
https://review.coreboot.org/c/coreboot/+/59367/comment/8968b39a_05624957 
PS3, Line 27: audio_codec->enabled = 1;
do you still want to enable it regardless of the probe?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59367
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d5b95e89154b2cb6b371f24cc1b151c23ff642f
Gerrit-Change-Number: 59367
Gerrit-PatchSet: 3
Gerrit-Owner: Malik Hsu malik_hsu@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com
Gerrit-Attention: Malik Hsu malik_hsu@wistron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 17 Nov 2021 16:14:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment