[XS] Change in coreboot[main]: device/oprom/include/x86emu/regs.h: Refactor code to match coding sty...
Attention is currently required from: Aryan Arora, Paul Menzel, Simon Glass.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80185?usp=email )
Change subject: device/oprom/include/x86emu/regs.h: Refactor code to match coding style standards ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80185/comment/ebd49e93_c8b88528 : PS1, Line 6:
If it helps, the comments are confusing as they refer to the line below. […]
Maybe "dev/oprom/inc/x86emu/regs.h: Refactor to match coding style"
https://review.coreboot.org/c/coreboot/+/80185/comment/5dfd533a_fcb75f60 : PS1, Line 6:
`A patch subject line should describe the change not the tool that found it` […]
I'm not sure what tool this is referring to. I think this complaint is incorrect.
Commit Message:
https://review.coreboot.org/c/coreboot/+/80185/comment/3d0569d4_2c4f25cb : PS2, Line 9: and Move this "and" to the following line.
Patchset:
PS2: Hi, It looks like you haven't contributed to the coreboot project before.
Welcome and thank you for the patch. We hope that this is just the first of many.
Please let us know if there's anything we can do to help get your first sets patches merged as you get used to the contribution process.
The coreboot project has a hands-off policy regarding other people's patches so nobody here is going to update the contents without your permission. If you would you like someone to take over your patches at any point, please just post a comment to that effect on the specific patch.
You might find the coding style guide and the gerrit guidelines useful to read.
https://doc.coreboot.org/contributing/coding_style.html https://doc.coreboot.org/contributing/gerrit_guidelines.html
If you want to talk with anyone, you can talk to developers on one of the many options we have:
https://doc.coreboot.org/community/forums.html
Again, please let us know if you have any questions, or if there's anything we can do to help.
I'm marking this as a +2 since the patch itself looks good, there's just an issue with the commit message.
-
Martin L Roth (Code Review)