Attention is currently required from: Elyes Haouas, Felix Held, Felix Singer, Jan Samek, Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75893?usp=email )
Change subject: doc/Makefile: Fix build dir setting
......................................................................
Patch Set 4: -Code-Review
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75893/comment/08c8b6de_bcace405 :
PS4, Line 16: and make it writable.
I assume this makes no difference, at least commit 4d8da8ed alone […]
Forgot that I can just read how it's called: In `makeSphinx.sh` we have
```
make sphinx BUILDDIR=/tmp/build
```
This `BUILDDIR=/tmp/build` got through even to the `Makefile.sphinx`.
What broke it is the different variable name. Because rn. we have
an explicit `BUILDDIR=` in the `Makefile` overriding the one from
the `makeSphinx.sh`.
Patchset:
PS4:
With the variable names the same, I don't understand the overall change
(before commit 4d8da8ed to after this one). The only effective difference
seems to be the added `mkdir -p`. Is this necessary?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75893?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc44134cf1996592597252aeb9dcf7ffb3378ee3
Gerrit-Change-Number: 75893
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 16 Jun 2023 13:35:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment