[XS] Change in coreboot[main]: soc/intel/common/block/pmc: Fix compilation error with MS4V=BIT(18)

[Subrata Banik (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Saurabh Mishra.

Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/84142?usp=email )

Change subject: soc/intel/common/block/pmc: Fix compilation error with MS4V=BIT(18)
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84142/comment/29e8f00b_c27b228c?usp... :
PS1, Line 9: If MS4V is defined using the BIT macro such in as in BIT(18) for
           : instance, it is replaced with (1ul << 18)
> A better solution would be to add a BIT_U macro for (1u << x), instead of typecasting.

not sure how can you define that as a better solution. It would limit the max left sight by 32-bit because in both 32-bit and 64-bit systems, an unsigned int is typically 32 bits wide. But we often use BIT() macro to manage bit > 31

if you are suggesting using a new macro named `BIT_32(x)` that uses (1u << x) then only it make sense but not for existing BIT() macro.