Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45232 )
Change subject: drivers/spi/tpm: Improve error checking
......................................................................
Patch Set 3:
(1 comment)
Patch Set 2:
lgtm, I am just curious where the 2 minute wait was and how does this help to avoid it.
the 2 minute wait is in wait_for_status() (same file).
with error checking, we bail out of tpm2_process_command()
earlier so we never reach the point where wait_for_status()
is called.
https://review.coreboot.org/c/coreboot/+/45232/2/src/drivers/spi/tpm/tpm.c
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/45232/2/src/drivers/spi/tpm/tpm.c@7...
PS2, Line 729: return 1;
nit: blank line before return
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45232
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8a1202000abce1857ee694b06b1478e6b045069
Gerrit-Change-Number: 45232
Gerrit-PatchSet: 3
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Sep 2020 04:34:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment