Change in coreboot[master]: mb/google/herobrine: Ensure board ID GPIOs are set - coreboot-gerrit

6 Jan 2022


      Attention is currently required from: Shelley Chen, Angel Pons, Julius Werner.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60795 )
Change subject: mb/google/herobrine: Ensure board ID GPIOs are set
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/60795/comment/214213b5_a913902a 
PS1, Line 25: 		dead_code();
...
Not related to this patch, but does QC SoC have extra ADCs? We've been using them for board IDs on M […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60795
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I863cd7acc31442333d8f73d1bd3a77f5c9978020
Gerrit-Change-Number: 60795
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Thu, 06 Jan 2022 01:44:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Comment-In-Reply-To: Shelley Chen shchen@google.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment